Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove deprecations after 24.11 branch-off #358735

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

wolfgangwalther
Copy link
Contributor

Continuation of #356732, but for stuff to be removed after 24.11's branch-off. Thus, no backport. I only grepped for "24.11", not for patterns like "to be removed in 25.05" - those have a lot more time.

IIUC, needs #356732 to be merged, because of overrideScope'.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 8.has: documentation This PR adds or changes documentation 6.topic: lib The Nixpkgs function library labels Nov 24, 2024
@wolfgangwalther
Copy link
Contributor Author

Result of nixpkgs-review pr 358735 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
1 package built:
  • nixpkgs-manual

Not much happening here.

@emilazy
Copy link
Member

emilazy commented Nov 24, 2024

I think we can do the 25.05 ones that don’t have immediate blockers too (e.g. CUDA stuff needs some work); better to get it over with early in the release cycle. (But non‐blocking.)

@wolfgangwalther
Copy link
Contributor Author

I think we can do the 25.05 ones that don’t have immediate blockers too (e.g. CUDA stuff needs some work); better to get it over with early in the release cycle. (But non‐blocking.)

That's true, but I don't want to step on anyone's toes more than I already do with this one. Whoever added those TODOs for 25.05 still has time.

@wolfgangwalther wolfgangwalther force-pushed the remove-deprecations-after-2411 branch from 9ec6aab to 8106962 Compare November 24, 2024 20:15
@github-actions github-actions bot added the 6.topic: cinnamon Desktop environment label Nov 24, 2024
@wolfgangwalther
Copy link
Contributor Author

I did add one more removal for pkgs.cinnamon, though. I missed that earlier. @bobby285271 @mkg20001 did I get the intention of that TODO right?

@nix-owners nix-owners bot requested a review from mkg20001 November 24, 2024 20:16
@bobby285271
Copy link
Member

bobby285271 commented Nov 24, 2024

Oh yes, removing the scope is my plan (other than the cinnamon-common rename, keeping the lib.warn spams a lot right now like the gnome scope).

Similar to #326687, do you mind also adding e.g. cinnamon = throw "The cinnamon scope has been removed and all packages have been moved to the top-level"; to pkgs/top-level/aliases.nix?

As the TODO says.
@wolfgangwalther wolfgangwalther force-pushed the remove-deprecations-after-2411 branch from 8106962 to 0944532 Compare November 25, 2024 07:54
@wolfgangwalther
Copy link
Contributor Author

Similar to #326687, do you mind also adding e.g. cinnamon = throw "The `cinnamon` scope has been removed and all packages have been moved to the top-level"; to pkgs/top-level/aliases.nix?

Did that!

@emilazy emilazy merged commit 29ef7a2 into NixOS:master Nov 25, 2024
17 of 18 checks passed
@wolfgangwalther wolfgangwalther deleted the remove-deprecations-after-2411 branch November 25, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cinnamon Desktop environment 6.topic: lib The Nixpkgs function library 6.topic: python 8.has: documentation This PR adds or changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants