Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] fwupd: 1.9.25 -> 2.0.1 #358659

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 24, 2024

Bot-based backport to release-24.11, triggered by a label in #351772.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

(cherry picked from commit 2c60d1d)
(cherry picked from commit 9e346f6)
@github-actions github-actions bot mentioned this pull request Nov 24, 2024
13 tasks
@r-vdp
Copy link
Contributor

r-vdp commented Nov 24, 2024

@ofborg eval

@JohnRTitor JohnRTitor closed this Nov 24, 2024
@JohnRTitor JohnRTitor reopened this Nov 24, 2024
@JohnRTitor
Copy link
Contributor

Instead of waiting for Ofborg eval, you can try out the new GH eval action.

However this does not automatically start for github-actions bot created PRs. So you can either force push, or quickly close+reopen the PR, like I have done now, to trigger the workflow (it will think that a human has opened the PR)

@JohnRTitor
Copy link
Contributor

@ofborg build fwupd fwupd.passthru.tests

@JohnRTitor
Copy link
Contributor

Merging this, tests and the package itself builds successfully.

@JohnRTitor JohnRTitor merged commit 4f871d8 into release-24.11 Nov 24, 2024
24 of 26 checks passed
@JohnRTitor JohnRTitor deleted the backport-351772-to-release-24.11 branch November 24, 2024 11:41
@bobby285271
Copy link
Member

bobby285271 commented Nov 24, 2024

Ugh I would consider this as breaking change? (Pantheon fixes are not in 24.11 and it will block the channel, cc @RossComputerGuy)

@r-vdp
Copy link
Contributor

r-vdp commented Nov 24, 2024

Ugh I would consider this as breaking change? (Pantheon fixes are not in 24.11 and it will block the channel, cc @RossComputerGuy)

Right, I didn't think of this, we should've run a nixpkgs-review on this which would've shown that.

@JohnRTitor would you mind reverting this? I'm on mobile and won't have access to my laptop for another day of two, so I can't do it myself.

@JohnRTitor
Copy link
Contributor

JohnRTitor commented Nov 24, 2024

Ugh I would consider this as breaking change?

Oof, I thought this was okay as 24.11 hasn't been released yet. But sure #358721

@r-vdp
Copy link
Contributor

r-vdp commented Nov 27, 2024

@bobby285271 do you think it would make sense to also backport the pantheon commits to the stable branch so that we can continue backporting fwupd version bumps?

@RossComputerGuy
Copy link
Member

can continue backporting fwupd version bumps?

I don't think we'd continue to backport updates, stable channels are for the most part using fixed versions.

@r-vdp
Copy link
Contributor

r-vdp commented Nov 28, 2024

I'm not sure what has been the backport policy for fwupd in the past, but there are definitely plenty of packages for which we do backport minor version bumps, and new fwupd releases often include bug fixes and additional hardware support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants