-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-24.11] fwupd: 1.9.25 -> 2.0.1 #358659
Conversation
@ofborg eval |
Instead of waiting for Ofborg eval, you can try out the new GH eval action. However this does not automatically start for github-actions bot created PRs. So you can either force push, or quickly close+reopen the PR, like I have done now, to trigger the workflow (it will think that a human has opened the PR) |
@ofborg build fwupd fwupd.passthru.tests |
Merging this, tests and the package itself builds successfully. |
Ugh I would consider this as breaking change? (Pantheon fixes are not in 24.11 and it will block the channel, cc @RossComputerGuy) |
Right, I didn't think of this, we should've run a nixpkgs-review on this which would've shown that. @JohnRTitor would you mind reverting this? I'm on mobile and won't have access to my laptop for another day of two, so I can't do it myself. |
Oof, I thought this was okay as 24.11 hasn't been released yet. But sure #358721 |
@bobby285271 do you think it would make sense to also backport the pantheon commits to the stable branch so that we can continue backporting fwupd version bumps? |
I don't think we'd continue to backport updates, stable channels are for the most part using fixed versions. |
I'm not sure what has been the backport policy for fwupd in the past, but there are definitely plenty of packages for which we do backport minor version bumps, and new fwupd releases often include bug fixes and additional hardware support. |
Bot-based backport to
release-24.11
, triggered by a label in #351772.