Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebsd: Add support for aarch64 #358053

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

artemist
Copy link
Member

Add a new aarch64-freebsd double and example system, then fix include and libc to work.
This is enough to build packages like hello,
either static or dynamic.

This is useful for testing nix FreeBSD on a Raspberry Pi.

Most of the challenging parts around compiler_rt were already upstreamed months ago.

If you'd like to test, it's easy to cross build a static binary (nix build .#pkgsCross.aarch64-freebsd.pkgsStatic.hello) and copy it to a FreeBSD raspberry pi and run it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small patch!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 22, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
Add a new `aarch64-freebsd` double and example system,
then fix include and libc to work.
This is enough to build packages like `hello`,
either static or dynamic.

This is useful for testing nix FreeBSD on a Raspberry Pi.
@artemist artemist requested a review from alyssais November 24, 2024 07:00
@Ericson2314 Ericson2314 merged commit 07f8638 into NixOS:master Nov 27, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants