Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequin: init at 0.2.0 #358034

Merged
merged 1 commit into from
Nov 28, 2024
Merged

sequin: init at 0.2.0 #358034

merged 1 commit into from
Nov 28, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 22, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

steeleduncan
steeleduncan suggested changes Nov 22, 2024
View reviewed changes
pkgs/by-name/se/sequin/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/se/sequin/package.nix Outdated Show resolved Hide resolved
@steeleduncan
Copy link
Contributor

You should squash the 3 commits into one

@caarlos0 caarlos0 force-pushed the sequin branch 3 times, most recently from 75111ee to 6d5923c Compare November 25, 2024 19:15
@caarlos0 caarlos0 changed the title sequin: init at 0.1.1 sequin: init at 0.2.0 Nov 25, 2024
@caarlos0
Copy link
Member Author

@steeleduncan done, also updated to latest sequin

@caarlos0 @donovanglover
sequin: init at 0.2.0
cac396d 
Signed-off-by: Carlos Alexandro Becker <[email protected]>

Co-authored-by: Donovan Glover <[email protected]>
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 27, 2024
@donovanglover donovanglover merged commit 49efe5e into NixOS:master Nov 28, 2024
34 of 35 checks passed
@caarlos0 caarlos0 deleted the sequin branch November 28, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steeleduncan steeleduncan steeleduncan requested changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@donovanglover donovanglover donovanglover approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caarlos0 @steeleduncan @donovanglover @Aleksanaa @wegank