Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostscript: fix dylib loading #357951

Closed
wants to merge 1 commit into from
Closed

ghostscript: fix dylib loading #357951

wants to merge 1 commit into from

Conversation

nolith
Copy link

@nolith nolith commented Nov 21, 2024 •
edited
Loading

Fixes #355377

$ otool -l result/bin/gs 

result/bin/gs:
[...]
Load command 13
          cmd LC_LOAD_DYLIB
      cmdsize 112
         name /nix/store/lk5rrxpwjvlx0sdik5zqzaibqsdjykcv-ghostscript-10.04.0/lib/libgs.10.dylib (offset 24)
   time stamp 2 Thu Jan  1 01:00:02 1970
      current version 0.0.0
compatibility version 0.0.0
[..]

Without this patch, the library is just libgs.10.dylib and gs cannot start.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 21, 2024
@nolith nolith mentioned this pull request Nov 21, 2024
Open
carlocab added a commit to carlocab/nixpkgs that referenced this pull request Nov 22, 2024
@carlocab
ghostscript: fix install names on Darwin
6e66aaf 
Fixes NixOS#355377.

This should avoid the need to mess around with `install_name_tool`
entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2].

This should also make the changes in NixOS#355853 and NixOS#357951 unnecessary.

[^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76
[^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114
@carlocab carlocab mentioned this pull request Nov 22, 2024
Merged
13 tasks
@carlocab
Copy link
Contributor

There's no need to use install_name_tool at all: #358079

@ofborg ofborg bot requested a review from viric November 22, 2024 13:21
emilazy pushed a commit that referenced this pull request Nov 25, 2024
@carlocab
ghostscript: fix install names on Darwin
8b3d3d5 
Fixes #355377.

This should avoid the need to mess around with `install_name_tool`
entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2].

This should also make the changes in #355853 and #357951 unnecessary.

[^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76
[^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114
osnyx pushed a commit to flyingcircusio/nixpkgs that referenced this pull request Nov 25, 2024
@carlocab @osnyx
ghostscript: fix install names on Darwin
7aae423 
Fixes NixOS#355377.

This should avoid the need to mess around with `install_name_tool`
entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2].

This should also make the changes in NixOS#355853 and NixOS#357951 unnecessary.

[^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76
[^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114

(cherry picked from commit 8b3d3d5)
vcunat pushed a commit that referenced this pull request Dec 4, 2024
@carlocab @vcunat
ghostscript: fix install names on Darwin
cdf3cf0 
Fixes #355377.

This should avoid the need to mess around with `install_name_tool`
entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2].

This should also make the changes in #355853 and #357951 unnecessary.

[^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76
[^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114

(cherry picked from commit 8b3d3d5)
@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Dec 4, 2024
nixpkgs-channel-update-tracker bot pushed a commit to flyingcircusio/nixpkgs that referenced this pull request Dec 4, 2024
@carlocab @nixpkgs-channel-update-tracker
ghostscript: fix install names on Darwin
d5af4dd 
Fixes NixOS#355377.

This should avoid the need to mess around with `install_name_tool`
entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2].

This should also make the changes in NixOS#355853 and NixOS#357951 unnecessary.

[^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76
[^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114

(cherry picked from commit 8b3d3d5)
nixpkgs-channel-update-tracker bot pushed a commit to flyingcircusio/nixpkgs that referenced this pull request Dec 4, 2024
@carlocab @nixpkgs-channel-update-tracker
ghostscript: fix install names on Darwin
c74a74a 
Fixes NixOS#355377.

This should avoid the need to mess around with `install_name_tool`
entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2].

This should also make the changes in NixOS#355853 and NixOS#357951 unnecessary.

[^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76
[^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114

(cherry picked from commit 8b3d3d5)
nixpkgs-channel-update-tracker bot pushed a commit to flyingcircusio/nixpkgs that referenced this pull request Dec 6, 2024
@carlocab @nixpkgs-channel-update-tracker
ghostscript: fix install names on Darwin
0b961bd 
Fixes NixOS#355377.

This should avoid the need to mess around with `install_name_tool`
entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2].

This should also make the changes in NixOS#355853 and NixOS#357951 unnecessary.

[^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76
[^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114

(cherry picked from commit 8b3d3d5)
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@wegank
Copy link
Member

wegank commented Dec 31, 2024

This PR is closed as part of the NixOS 24.05 EOL Cleanup: https://nixos.github.io/release-wiki/EOL-Cleanup.html

@wegank wegank closed this Dec 31, 2024
@vcunat
Copy link
Member

vcunat commented Dec 31, 2024

The other PR got merged, so I hope it's OK anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12. first-time contribution This PR is the author's first one; please be gentle! awaiting_changes (old Marvin label, do not use)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nolith @carlocab @wegank @vcunat @FliegendeWurst @NixOSInfra