Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.11 backport] nodejs_20: 20.18.0 -> 20.18.1 #357686

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 20, 2024

Things done

Backport of #357609

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aduh95 aduh95 changed the title nodejs_20: 20.18.0 -> 20.18.1 [24.11 backport] nodejs_20: 20.18.0 -> 20.18.1 Nov 20, 2024
@aduh95 aduh95 mentioned this pull request Nov 20, 2024
13 tasks
@emilazy emilazy merged commit b5d2277 into NixOS:staging-24.11 Nov 20, 2024
17 of 18 checks passed
Copy link
Contributor

Backport failed for staging-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.05
git worktree add -d .worktree/backport-357686-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-357686-to-staging-24.05
git switch --create backport-357686-to-staging-24.05
git cherry-pick -x a8ae089509e1f915decfea7df6d59a5fa3c2b861

@aduh95 aduh95 deleted the nodejs_20 branch November 20, 2024 22:36
@emilazy
Copy link
Member

emilazy commented Nov 20, 2024

Aw c’mon backport bot…

@aduh95
Copy link
Contributor Author

aduh95 commented Nov 20, 2024

I think it's behind a few v20.x updates on staging-24.05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants