Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poppler: format, add dependency for glib-mkenums to fix cross building #357344

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

jwillikers
Copy link
Contributor

Cross-building poppler is broken:

nix build .#pkgsCross.aarch64-multiplatform.poppler
error: builder for '/nix/store/xkgfqac2i1wz692ijvhqrb06gd2y2hba-poppler-glib-aarch64-unknown-linux-gnu-24.02.0.drv' failed with exit code 1;
       last 25 log lines:
       > [136/184] Building CXX object cpp/CMakeFiles/poppler-cpp.dir/poppler-document.cpp.o
       > [137/184] Building CXX object cpp/CMakeFiles/poppler-cpp.dir/poppler-toc.cpp.o
       > [138/184] Building CXX object test/CMakeFiles/cairo-thread-test.dir/__/poppler/CairoRescaleBox.cc.o
       > [139/184] Building CXX object test/CMakeFiles/pdf-fullrewrite.dir/__/utils/parseargs.cc.o
       > [140/184] Building CXX object cpp/CMakeFiles/poppler-cpp.dir/poppler-page.cpp.o
       > [141/184] Building CXX object CMakeFiles/poppler.dir/poppler/PSOutputDev.cc.o
       > [142/184] Building CXX object test/CMakeFiles/image-embedding.dir/__/utils/parseargs.cc.o
       > [143/184] Building CXX object cpp/tests/CMakeFiles/poppler-dump.dir/__/__/utils/parseargs.cc.o
       > [144/184] Linking CXX shared library libpoppler.so.134.0.0
       > [145/184] Creating library symlink libpoppler.so.134 libpoppler.so
       > [146/184] Generating poppler-enums.h
       > FAILED: glib/poppler-enums.h /build/poppler-24.02.0/build/glib/poppler-enums.h
       > cd /build/poppler-24.02.0/glib && /nix/store/px2nj16i5gc3d4mnw5l1nclfdxhry61p-python3-3.12.7/bin/python3 GLIB2_MKENUMS-NOTFOUND --template poppler-enums.h.template poppler-action.h poppler-date.h poppler-document.h poppler-page.h poppler-attachment.h poppler-form-field.h poppler-annot.h poppler-layer.h poppler-movie.h poppler-media.h poppler.h poppler-structure-element.h > /build/poppler-24.02.0/build/glib/poppler-enums.h
       > /nix/store/px2nj16i5gc3d4mnw5l1nclfdxhry61p-python3-3.12.7/bin/python3: can't open file '/build/poppler-24.02.0/glib/GLIB2_MKENUMS-NOTFOUND': [Errno 2] No such file or directory
       > [147/184] Building CXX object test/CMakeFiles/perf-test.dir/perf-test.cc.o
       > [148/184] Linking CXX shared library cpp/libpoppler-cpp.so.0.11.0
       > [149/184] Building CXX object cpp/tests/CMakeFiles/poppler-render.dir/__/__/utils/parseargs.cc.o
       > [150/184] Building CXX object test/CMakeFiles/image-embedding.dir/image-embedding.cc.o
       > [151/184] Building CXX object cpp/tests/CMakeFiles/poppler-render.dir/poppler-render.cpp.o
       > [152/184] Building CXX object test/CMakeFiles/pdf-fullrewrite.dir/pdf-fullrewrite.cc.o
       > [153/184] Building CXX object cpp/tests/CMakeFiles/poppler-dump.dir/poppler-dump.cpp.o
       > [154/184] Building CXX object test/CMakeFiles/cairo-thread-test.dir/__/poppler/CairoFontEngine.cc.o
       > [155/184] Building CXX object test/CMakeFiles/cairo-thread-test.dir/cairo-thread-test.cc.o
       > [156/184] Building CXX object test/CMakeFiles/cairo-thread-test.dir/__/poppler/CairoOutputDev.cc.o
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/xkgfqac2i1wz692ijvhqrb06gd2y2hba-poppler-glib-aarch64-unknown-linux-gnu-24.02.0.drv'.

This PR adds the missing dependency on glib-mkenums.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Nov 20, 2024
@ofborg ofborg bot requested review from ttuegel and jtojnar November 21, 2024 07:09
@uninsane
Copy link
Contributor

oh, rebuild count is 501-1000: it might be good to target this against staging

@uninsane uninsane added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
@jwillikers jwillikers marked this pull request as draft November 23, 2024 01:04
@jwillikers jwillikers changed the base branch from master to staging November 23, 2024 01:05
@jwillikers jwillikers marked this pull request as ready for review November 23, 2024 01:05
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
@jwillikers jwillikers marked this pull request as draft November 23, 2024 12:44
@jwillikers jwillikers marked this pull request as ready for review November 23, 2024 12:45
@uninsane uninsane added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
@jtojnar jtojnar mentioned this pull request Nov 24, 2024
13 tasks
@jwillikers jwillikers marked this pull request as draft November 24, 2024 14:17
@jwillikers jwillikers marked this pull request as ready for review November 24, 2024 14:20
@uninsane uninsane added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 24, 2024
@uninsane uninsane merged commit 0f2cb3b into NixOS:staging Nov 28, 2024
36 of 37 checks passed
@jwillikers jwillikers deleted the poppler-cross branch November 28, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants