nixos/mopidy: restart the systemd service on failure #357250
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
getchoo
requested changes
Nov 19, 2024
| @@ -83,6 +83,7 @@ in { | |||
| description = "mopidy music player daemon"; | |||
| serviceConfig = { | |||
| ExecStart = "${mopidyEnv}/bin/mopidy --config ${concatStringsSep ":" ([mopidyConf] ++ cfg.extraConfigFiles)}"; | |||
| Restart = "always"; | |||
There was a problem hiding this comment.
Suggested change
| Restart = "always"; | |
| Restart = "on-failure"; |
This is what's recommended upstream and helps prevent the service from restarting even when you are trying to stop it
There was a problem hiding this comment.
Indeed, thank you. I've updated this.
jwillikers
force-pushed
the
nixos-mopidy-restart-always
branch
from
024c1df to
b4cdb57
Compare
getchoo
approved these changes
Nov 19, 2024
getchoo
added
the
12.approvals: 1
jwillikers
changed the title
ofborg
bot
added
10.rebuild-darwin: 0
This ensures Mopidy is running, even after crashes.
jwillikers
force-pushed
the
nixos-mopidy-restart-always
branch
from
b4cdb57 to
90dfafe
Compare
getchoo
approved these changes
Nov 26, 2024
Stunkymonkey
approved these changes
Nov 27, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-357250-to-release-24.11 origin/release-24.11
cd .worktree/backport-357250-to-release-24.11
git switch --create backport-357250-to-release-24.11
git cherry-pick -x 90dfafee359919d2574139ce4da1c896b45e5d4e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures Mopidy is running, even after crashes.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.