[release-24.05] vaultwarden: 1.32.1 -> 1.32.4

[mweinelt]

https://github.com/dani-garcia/vaultwarden/releases/tag/1.32.2
https://github.com/dani-garcia/vaultwarden/releases/tag/1.32.3
https://github.com/dani-garcia/vaultwarden/releases/tag/1.32.4

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

Diff: dani-garcia/[email protected]

Changelog: https://github.com/dani-garcia/vaultwarden/releases/tag/1.32.2
(cherry picked from commit fe9ef3a)

[mweinelt]

Fails to build due to rust 1.80 pin and they mean it.

   Compiling diesel v2.2.4
error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:102:9
    |
102 |     use std::sync::LazyLock;
    |         ^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:103:16
    |
103 |     static RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"<[^>]+>").unwrap());
    |                ^^^^^^^^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:103:34
    |
103 |     static RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"<[^>]+>").unwrap());
    |                                  ^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:102:9
    |
102 |     use std::sync::LazyLock;
    |         ^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:103:16
    |
103 |     static RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"<[^>]+>").unwrap());
    |                ^^^^^^^^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:103:34
    |
103 |     static RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"<[^>]+>").unwrap());
    |                                  ^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:103:34
    |
103 |     static RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"<[^>]+>").unwrap());
    |                                  ^^^^^^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

   Compiling diesel_migrations v2.2.0
error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:102:9
    |
102 |     use std::sync::LazyLock;
    |         ^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:103:16
    |
103 |     static RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"<[^>]+>").unwrap());
    |                ^^^^^^^^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:103:34
    |
103 |     static RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"<[^>]+>").unwrap());
    |                                  ^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

error[E0658]: use of unstable library feature 'lazy_cell'
   --> src/mail.rs:103:34
    |
103 |     static RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"<[^>]+>").unwrap());
    |                                  ^^^^^^^^^^^^^
    |
    = note: see issue #109736 <https://github.com/rust-lang/rust/issues/109736> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `vaultwarden` (bin "vaultwarden") due to 4 previous errors

[dotlambda]

@K900 I hope now you see that merging this fast is not a good idea.
I was actually in the process of preparing a true backport including a Rust bump but I lost motivation. Please deal with this mess yourself. You're annoying.

[K900]

I understand my mistake now, and apologize. I will make a mental note not to merge updates to Vaultwarden anymore without explicit maintainer approval.

[dotlambda]

I will make a mental note not to merge updates to Vaultwarden anymore without explicit maintainer approval.

It's okay to do so, if you give maintainers at least some time to respond.
And please don't limit this to Vaultwarden. It should be applied to all packages.

[emilazy]

Please deal with this mess yourself. You're annoying.

@dotlambda You need to be more civil when people do things you don’t like. Rushed handling or not, it’s been months now that I’ve seen you overstep the CoC and do your own unreviewed self‐merged reverts whenever you’re irritated by other contributors, sometimes for things as simple and harmless as not respecting your priority for trivial updates, and I am becoming seriously concerned by it.

(FWIW CI broke on the original PR because the GitHub Action workflows are written incorrectly and always fail on merged PRs.)

[dotlambda]

You need to be more civil when people do things you don’t like.

I'll tone down. And yeah, you're totally right that I haven't always been nice in the past.
One thing I want to emphasize though is that there are rules other than the CoC. I'll start following the latter better and would appreciate if @K900 did so w.r.t. giving maintainers appropriate time to review.