-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/home-assistant: add support for amshan #355055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Nov 10, 2024
bjornfor
force-pushed
the
add-amshan-homeassistant
branch
from
November 10, 2024 20:15
2769c10
to
448f977
Compare
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Nov 11, 2024
wegank
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Dec 10, 2024
bjornfor
force-pushed
the
add-amshan-homeassistant
branch
from
January 8, 2025 20:20
448f977
to
75ed908
Compare
bjornfor
removed
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Jan 11, 2025
bjornfor
force-pushed
the
add-amshan-homeassistant
branch
from
January 12, 2025 19:09
75ed908
to
65ce40c
Compare
mweinelt
requested changes
Jan 12, 2025
pkgs/servers/home-assistant/custom-components/amshan-homeassistant/package.nix
Outdated
Show resolved
Hide resolved
bjornfor
force-pushed
the
add-amshan-homeassistant
branch
2 times, most recently
from
January 13, 2025 08:40
80284d9
to
a6a3181
Compare
bjornfor
force-pushed
the
add-amshan-homeassistant
branch
2 times, most recently
from
January 13, 2025 09:19
0dd99a3
to
ee064f4
Compare
mweinelt
reviewed
Jan 13, 2025
pkgs/servers/home-assistant/custom-components/amshan-homeassistant/package.nix
Outdated
Show resolved
Hide resolved
Separate it from the first part of the list, because that part is updated mechanically.
bjornfor
force-pushed
the
add-amshan-homeassistant
branch
from
January 13, 2025 15:07
ee064f4
to
bbcb277
Compare
mweinelt
approved these changes
Jan 13, 2025
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: python
8.has: module (update)
This PR changes an existing module in `nixos/`
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
backport release-24.11
Backport PR automatically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Package amshan-homeassistant and enable required serial port access in the NixOS module for home-assistant.
With these changes[1] I successfully got data from my electricity meter (via a small USB to MBUS slave adapter).
[1] I tested on NixOS 24.11, then rebased onto master.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.