Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/home-assistant: add support for amshan #355055

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Nov 10, 2024

Things done

Package amshan-homeassistant and enable required serial port access in the NixOS module for home-assistant.

With these changes[1] I successfully got data from my electricity meter (via a small USB to MBUS slave adapter).

[1] I tested on NixOS 24.11, then rebased onto master.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 10, 2024
@bjornfor bjornfor force-pushed the add-amshan-homeassistant branch from 2769c10 to 448f977 Compare November 10, 2024 20:15
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 11, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@bjornfor bjornfor force-pushed the add-amshan-homeassistant branch from 448f977 to 75ed908 Compare January 8, 2025 20:20
@bjornfor bjornfor removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 11, 2025
@bjornfor bjornfor force-pushed the add-amshan-homeassistant branch from 75ed908 to 65ce40c Compare January 12, 2025 19:09
@bjornfor bjornfor marked this pull request as ready for review January 12, 2025 19:09
@nix-owners nix-owners bot requested review from natsukium and mweinelt January 12, 2025 19:11
@bjornfor bjornfor force-pushed the add-amshan-homeassistant branch 2 times, most recently from 80284d9 to a6a3181 Compare January 13, 2025 08:40
@bjornfor bjornfor force-pushed the add-amshan-homeassistant branch 2 times, most recently from 0dd99a3 to ee064f4 Compare January 13, 2025 09:19
Separate it from the first part of the list, because that part is
updated mechanically.
@bjornfor bjornfor force-pushed the add-amshan-homeassistant branch from ee064f4 to bbcb277 Compare January 13, 2025 15:07
@mweinelt mweinelt merged commit c30df4f into NixOS:master Jan 13, 2025
25 of 28 checks passed
@bjornfor bjornfor deleted the add-amshan-homeassistant branch January 13, 2025 16:58
@bjornfor bjornfor added the backport release-24.11 Backport PR automatically label Jan 13, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 13, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants