Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opengist: 1.7.5 -> 1.8.3 #354830

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

phanirithvij
Copy link
Member

@phanirithvij phanirithvij commented Nov 9, 2024

  • added an update script
  • upstreamed a few cross platform build error fixes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@phanirithvij
Copy link
Member Author

phanirithvij commented Nov 9, 2024

@ofborg build opengist

EDIT: failed on aarch64-linux, x86_64-darwin

@phanirithvij phanirithvij marked this pull request as draft November 9, 2024 21:24
@phanirithvij phanirithvij force-pushed the opengist-upd-181 branch 2 times, most recently from 634de67 to 2a55440 Compare November 10, 2024 10:26
@phanirithvij phanirithvij marked this pull request as ready for review November 10, 2024 10:38
@phanirithvij phanirithvij marked this pull request as draft November 10, 2024 12:10
@phanirithvij

This comment was marked as outdated.

@phanirithvij phanirithvij changed the title opengist: 1.7.5 -> 1.8.1 WIP: opengist: 1.7.5 -> 1.8.1 Nov 10, 2024
@phanirithvij phanirithvij force-pushed the opengist-upd-181 branch 5 times, most recently from d26fe31 to 3684728 Compare November 10, 2024 19:11
@phanirithvij phanirithvij changed the title WIP: opengist: 1.7.5 -> 1.8.1 opengist: 1.7.5 -> 1.8.2 Nov 26, 2024
@phanirithvij phanirithvij marked this pull request as ready for review November 26, 2024 11:18
@phanirithvij phanirithvij force-pushed the opengist-upd-181 branch 3 times, most recently from 82eda2d to 5084188 Compare November 26, 2024 12:41
@phanirithvij phanirithvij marked this pull request as draft November 26, 2024 22:26
@phanirithvij phanirithvij force-pushed the opengist-upd-181 branch 2 times, most recently from 6bf7086 to 15fedd9 Compare November 26, 2024 22:54
@phanirithvij phanirithvij force-pushed the opengist-upd-181 branch 2 times, most recently from 9ab1aea to 86599eb Compare November 26, 2024 23:14
@phanirithvij
Copy link
Member Author

@ofborg build opengist

@phanirithvij phanirithvij changed the title opengist: 1.7.5 -> 1.8.2 opengist: 1.7.5 -> 1.8.3 Nov 27, 2024
@phanirithvij phanirithvij marked this pull request as ready for review November 27, 2024 04:40
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2138

@phanirithvij
Copy link
Member Author

@khaneliman hope you don't mind reviewing. There has been many bug fixes since 1.7.5 for this package.

Co-authored-by: Sandro <[email protected]>
Signed-off-by: phanirithvij <[email protected]>
@SuperSandro2000
Copy link
Member

@ofborg build opengist

@SuperSandro2000 SuperSandro2000 merged commit 3df5758 into NixOS:master Dec 6, 2024
41 of 43 checks passed
@phanirithvij phanirithvij deleted the opengist-upd-181 branch December 6, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants