cygwin: add as a cross-compilation target, and get bash.exe to compile #354137
+415
−36
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| --- winsup/configure.old 2024-11-01 22:38:21.005768397 +1100 | ||
| +++ winsup/configure 2024-11-01 22:39:33.247435255 +1100 | ||
| @@ -3970,155 +3970,6 @@ | ||
| _ACEOF | ||
| ac_clean_files_save=$ac_clean_files | ||
| ac_clean_files="$ac_clean_files a.out a.out.dSYM a.exe b.out" | ||
| -# Try to create an executable without -o first, disregard a.out. | ||
| -# It will help us diagnose broken compilers, and finding out an intuition | ||
| -# of exeext. | ||
| -{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking whether the C compiler works" >&5 | ||
| -printf %s "checking whether the C compiler works... " >&6; } | ||
| -ac_link_default=`printf "%s\n" "$ac_link" | sed 's/ -o *conftest[^ ]*//'` | ||
| - | ||
| -# The possible output files: | ||
| -ac_files="a.out conftest.exe conftest a.exe a_out.exe b.out conftest.*" | ||
| - | ||
| -ac_rmfiles= | ||
| -for ac_file in $ac_files | ||
| -do | ||
| - case $ac_file in | ||
| - *.$ac_ext | *.xcoff | *.tds | *.d | *.pdb | *.xSYM | *.bb | *.bbg | *.map | *.inf | *.dSYM | *.o | *.obj ) ;; | ||
| - * ) ac_rmfiles="$ac_rmfiles $ac_file";; | ||
| - esac | ||
| -done | ||
| -rm -f $ac_rmfiles | ||
| - | ||
| -if { { ac_try="$ac_link_default" | ||
| -case "(($ac_try" in | ||
| - *\"* | *\`* | *\\*) ac_try_echo=\$ac_try;; | ||
| - *) ac_try_echo=$ac_try;; | ||
| -esac | ||
| -eval ac_try_echo="\"\$as_me:${as_lineno-$LINENO}: $ac_try_echo\"" | ||
| -printf "%s\n" "$ac_try_echo"; } >&5 | ||
| - (eval "$ac_link_default") 2>&5 | ||
| - ac_status=$? | ||
| - printf "%s\n" "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 | ||
| - test $ac_status = 0; } | ||
| -then : | ||
| - # Autoconf-2.13 could set the ac_cv_exeext variable to 'no'. | ||
| -# So ignore a value of 'no', otherwise this would lead to 'EXEEXT = no' | ||
| -# in a Makefile. We should not override ac_cv_exeext if it was cached, | ||
| -# so that the user can short-circuit this test for compilers unknown to | ||
| -# Autoconf. | ||
| -for ac_file in $ac_files '' | ||
| -do | ||
| - test -f "$ac_file" || continue | ||
| - case $ac_file in | ||
| - *.$ac_ext | *.xcoff | *.tds | *.d | *.pdb | *.xSYM | *.bb | *.bbg | *.map | *.inf | *.dSYM | *.o | *.obj ) | ||
| - ;; | ||
| - [ab].out ) | ||
| - # We found the default executable, but exeext='' is most | ||
| - # certainly right. | ||
| - break;; | ||
| - *.* ) | ||
| - if test ${ac_cv_exeext+y} && test "$ac_cv_exeext" != no; | ||
| - then :; else | ||
| - ac_cv_exeext=`expr "$ac_file" : '[^.]*\(\..*\)'` | ||
| - fi | ||
| - # We set ac_cv_exeext here because the later test for it is not | ||
| - # safe: cross compilers may not add the suffix if given an '-o' | ||
| - # argument, so we may need to know it at that point already. | ||
| - # Even if this section looks crufty: it has the advantage of | ||
| - # actually working. | ||
| - break;; | ||
| - * ) | ||
| - break;; | ||
| - esac | ||
| -done | ||
| -test "$ac_cv_exeext" = no && ac_cv_exeext= | ||
| - | ||
| -else case e in #( | ||
| - e) ac_file='' ;; | ||
| -esac | ||
| -fi | ||
| -if test -z "$ac_file" | ||
| -then : | ||
| - { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: no" >&5 | ||
| -printf "%s\n" "no" >&6; } | ||
| -printf "%s\n" "$as_me: failed program was:" >&5 | ||
| -sed 's/^/| /' conftest.$ac_ext >&5 | ||
| - | ||
| -{ { printf "%s\n" "$as_me:${as_lineno-$LINENO}: error: in '$ac_pwd':" >&5 | ||
| -printf "%s\n" "$as_me: error: in '$ac_pwd':" >&2;} | ||
| -as_fn_error 77 "C compiler cannot create executables | ||
| -See 'config.log' for more details" "$LINENO" 5; } | ||
| -else case e in #( | ||
| - e) { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: yes" >&5 | ||
| -printf "%s\n" "yes" >&6; } ;; | ||
| -esac | ||
| -fi | ||
| -{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking for C compiler default output file name" >&5 | ||
| -printf %s "checking for C compiler default output file name... " >&6; } | ||
| -{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $ac_file" >&5 | ||
| -printf "%s\n" "$ac_file" >&6; } | ||
| -ac_exeext=$ac_cv_exeext | ||
| - | ||
| -rm -f -r a.out a.out.dSYM a.exe conftest$ac_cv_exeext b.out | ||
| -ac_clean_files=$ac_clean_files_save | ||
| -{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking for suffix of executables" >&5 | ||
| -printf %s "checking for suffix of executables... " >&6; } | ||
| -if { { ac_try="$ac_link" | ||
| -case "(($ac_try" in | ||
| - *\"* | *\`* | *\\*) ac_try_echo=\$ac_try;; | ||
| - *) ac_try_echo=$ac_try;; | ||
| -esac | ||
| -eval ac_try_echo="\"\$as_me:${as_lineno-$LINENO}: $ac_try_echo\"" | ||
| -printf "%s\n" "$ac_try_echo"; } >&5 | ||
| - (eval "$ac_link") 2>&5 | ||
| - ac_status=$? | ||
| - printf "%s\n" "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 | ||
| - test $ac_status = 0; } | ||
| -then : | ||
| - # If both 'conftest.exe' and 'conftest' are 'present' (well, observable) | ||
| -# catch 'conftest.exe'. For instance with Cygwin, 'ls conftest' will | ||
| -# work properly (i.e., refer to 'conftest.exe'), while it won't with | ||
| -# 'rm'. | ||
| -for ac_file in conftest.exe conftest conftest.*; do | ||
| - test -f "$ac_file" || continue | ||
| - case $ac_file in | ||
| - *.$ac_ext | *.xcoff | *.tds | *.d | *.pdb | *.xSYM | *.bb | *.bbg | *.map | *.inf | *.dSYM | *.o | *.obj ) ;; | ||
| - *.* ) ac_cv_exeext=`expr "$ac_file" : '[^.]*\(\..*\)'` | ||
| - break;; | ||
| - * ) break;; | ||
| - esac | ||
| -done | ||
| -else case e in #( | ||
| - e) { { printf "%s\n" "$as_me:${as_lineno-$LINENO}: error: in '$ac_pwd':" >&5 | ||
| -printf "%s\n" "$as_me: error: in '$ac_pwd':" >&2;} | ||
| -as_fn_error $? "cannot compute suffix of executables: cannot compile and link | ||
| -See 'config.log' for more details" "$LINENO" 5; } ;; | ||
| -esac | ||
| -fi | ||
| -rm -f conftest conftest$ac_cv_exeext | ||
| -{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $ac_cv_exeext" >&5 | ||
| -printf "%s\n" "$ac_cv_exeext" >&6; } | ||
| - | ||
| -rm -f conftest.$ac_ext | ||
| -EXEEXT=$ac_cv_exeext | ||
| -ac_exeext=$EXEEXT | ||
| -cat confdefs.h - <<_ACEOF >conftest.$ac_ext | ||
| -/* end confdefs.h. */ | ||
| -#include <stdio.h> | ||
| -int | ||
| -main (void) | ||
| -{ | ||
| -FILE *f = fopen ("conftest.out", "w"); | ||
| - if (!f) | ||
| - return 1; | ||
| - return ferror (f) || fclose (f) != 0; | ||
| - | ||
| - ; | ||
| - return 0; | ||
| -} | ||
| -_ACEOF | ||
| -ac_clean_files="$ac_clean_files conftest.out" | ||
| # Check that the compiler produces executables we can run. If not, either | ||
| # the compiler is broken, or we cross compile. | ||
| { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking whether we are cross compiling" >&5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| { | ||
| lib, | ||
| stdenv, | ||
| cygwin_headers, | ||
| buildPackages, | ||
| automake, | ||
| autoconf, | ||
| bison, | ||
| cocom-tool-set, | ||
| flex, | ||
| perl, | ||
| mingw_w64, | ||
| }: | ||
|
|
||
| stdenv.mkDerivation { | ||
| pname = "cygwin"; | ||
|
|
||
| inherit (cygwin_headers) | ||
| version | ||
| src | ||
| meta | ||
| patches | ||
| ; | ||
|
|
||
| preConfigure = '' | ||
| pushd winsup | ||
| aclocal --force | ||
| autoconf -f | ||
| automake -ac | ||
| rm -rf autom4te.cache | ||
| popd | ||
| patch -p0 -i ${./after-autogen.patch} | ||
| ''; | ||
|
|
||
| postPatch = '' | ||
| patchShebangs --build winsup/cygwin/scripts | ||
| ''; | ||
|
|
||
| env.CXXFLAGS_FOR_TARGET = "-Wno-error"; | ||
|
|
||
| depsBuildBuild = [ buildPackages.stdenv.cc ]; | ||
| nativeBuildInputs = [ | ||
| autoconf | ||
| automake | ||
| bison | ||
| cocom-tool-set | ||
| flex | ||
| perl | ||
| ]; | ||
| buildInputs = [ mingw_w64 ]; | ||
|
|
||
| hardeningDisable = [ "fortify" ]; | ||
| configurePlatforms = [ | ||
| "build" | ||
| "target" | ||
| ]; | ||
| configureFlags = [ | ||
| "--disable-shared" | ||
| "--disable-doc" | ||
| "--enable-static" | ||
| "--disable-dumper" | ||
| "--with-cross-bootstrap" | ||
| "ac_cv_prog_CC=gcc" | ||
|
There was a problem hiding this comment. Why? This looks like it's hardcoding an assumption that the compiler is GCC. |
||
| ]; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we instead patch
configure.acand regen withautoreconfHook?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. This was copied from Microsoft's Windows-on-ARM-Experiments repository. Not sure why it was done that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh probably because they are lazy af lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why copied and not fetched? If you used fetchpatch you could even use
extraPrefixto make it so you can just put it inpatches.