Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taisei: 1.3.2 -> 1.4.2; modernize; add myself as maintainer #353696

Merged
merged 5 commits into from
Nov 9, 2024
Merged

taisei: 1.3.2 -> 1.4.2; modernize; add myself as maintainer #353696

merged 5 commits into from
Nov 9, 2024

Conversation

Gliczy
Copy link
Member

@Gliczy Gliczy commented Nov 4, 2024

https://github.com/taisei-project/taisei/releases/tag/v1.4
https://github.com/taisei-project/taisei/releases/tag/v1.4.1
https://github.com/taisei-project/taisei/releases/tag/v1.4.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Gliczy
Copy link
Member Author

Gliczy commented Nov 4, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353696

x86_64-linux

✅ 1 package built:
  • taisei

@Gliczy Gliczy force-pushed the taisei branch 2 times, most recently from e675fdd to 23fd859 Compare November 4, 2024 23:11
TomaSajt
TomaSajt approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@TomaSajt TomaSajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Runs fine on Linux
Seems to build and run on Darwin (though it's very slow since I use a VM without hardware acceleration)

@ofborg ofborg bot requested a review from lambda-11235 November 5, 2024 08:57
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 5, 2024
@khaneliman khaneliman merged commit 7e248e1 into NixOS:master Nov 9, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomaSajt TomaSajt TomaSajt approved these changes

@khaneliman khaneliman khaneliman approved these changes

@lambda-11235 lambda-11235 Awaiting requested review from lambda-11235

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gliczy @khaneliman @TomaSajt @wegank