Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kaufkauflist: 4.0.0 -> 4.0.2 #353679

Merged
merged 1 commit into from
Jan 2, 2025
Merged

kaufkauflist: 4.0.0 -> 4.0.2 #353679

merged 1 commit into from
Jan 2, 2025
+27 −20

Conversation

auroraanna
Copy link
Contributor

@auroraanna auroraanna commented Nov 4, 2024 •
edited
Loading

updated kaufkauflist to newest version.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@auroraanna auroraanna self-assigned this Nov 5, 2024
@auroraanna auroraanna added the 8.has: package (update) This PR updates a package to a newer version label Nov 5, 2024
@auroraanna auroraanna marked this pull request as ready for review November 5, 2024 19:33
@auroraanna auroraanna requested a review from momeemt November 5, 2024 19:43
momeemt
momeemt approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@momeemt
Copy link
Member

momeemt commented Nov 6, 2024

Result of nixpkgs-review pr 353679 run on aarch64-darwin 1

1 package failed to build:
  • kaufkauflist

momeemt
momeemt suggested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for approve by mistake earlier. It fails to be built on aarch64-darwin.

pkgs/by-name/ka/kaufkauflist/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@auroraanna
Copy link
Contributor Author

fixed the merge conflict

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 18, 2024
@auroraanna auroraanna requested a review from momeemt November 30, 2024 15:06
@auroraanna auroraanna requested a review from nbraud December 27, 2024 07:11
@momeemt
Copy link
Member

momeemt commented Jan 2, 2025

Result of nixpkgs-review pr 353679 run on aarch64-darwin 1

1 package built:
  • kaufkauflist

momeemt
momeemt approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. LGTM.

@momeemt momeemt added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 2, 2025
@ck3d ck3d merged commit aa16270 into NixOS:master Jan 2, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momeemt momeemt momeemt approved these changes

@nbraud nbraud Awaiting requested review from nbraud

Assignees

@auroraanna auroraanna

Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@auroraanna @momeemt @wegank @ck3d