Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossip: 0.11.2 -> 0.12.0; fix build #353652

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Nov 4, 2024

Changelog: https://github.com/mikedilger/gossip/releases/tag/v0.12.0

Fixes https://hydra.nixos.org/build/275999067/nixlog/51 by pinning ffmpeg to v6.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft msanft requested a review from katexochen November 4, 2024 14:38
@katexochen katexochen added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 4, 2024
@Scrumplex
Copy link
Member

Scrumplex commented Nov 4, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353652


x86_64-linux

✅ 1 package built:
  • gossip

EDIT: my aarch64 builder is unreliable. Ignore this

aarch64-linux

❌ 1 package failed to build:
  • gossip

aarch64-darwin

✅ 1 package built:
  • gossip

@katexochen katexochen merged commit c1d8fe0 into NixOS:master Nov 5, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants