Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresqlPackages.pg_net: 0.8.0 -> 0.11.0 #353532

Closed
wants to merge 4 commits into from
Closed

Conversation

samrose
Copy link
Contributor

@samrose samrose commented Nov 3, 2024

Update pg_net to 0.11.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from thoughtpolice November 3, 2024 23:22
@samrose
Copy link
Contributor Author

samrose commented Nov 4, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@samrose merge not permitted (#305350):
pkgs/servers/sql/postgresql/ext/pg_net.nix is not in pkgs/by-name/

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4799

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 4, 2024
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NixOS/nixpkgs-merge-bot merge

I don't think you can reasonably expect to be able to use this command, for which you need to be a maintainer already, while adding yourself as one in the same PR. Independent of whether that's already in by-name or not.

pkgs/servers/sql/postgresql/ext/pg_net.nix Show resolved Hide resolved
maintainers = with maintainers; [ thoughtpolice ];
maintainers = with maintainers; [ thoughtpolice samrose ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself as maintainer in a separate commit. See https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in de015f4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still in this commit and then you were just removed in a later commit.

@wolfgangwalther
Copy link
Contributor

I don't think you can reasonably expect to be able to use this command, for which you need to be a maintainer already, while adding yourself as one in the same PR.

That being said, it's kind of odd that ofborg adds the 11.by: package-maintainer label...

@wolfgangwalther
Copy link
Contributor

Also note the commit messages should start with postgresqlPackages.pg_net: ....

@samrose
Copy link
Contributor Author

samrose commented Nov 5, 2024

@NixOS/nixpkgs-merge-bot merge

I don't think you can reasonably expect to be able to use this command, for which you need to be a maintainer already, while adding yourself as one in the same PR. Independent of whether that's already in by-name or not.

Thanks for that info. It's been some time since I have put through PR into nixpkgs, and it wasn't clear from contributing docs what various permissions are needed for these actions. But that makes sense and thank you for the clarification.

@nix-owners nix-owners bot requested a review from Ma27 November 5, 2024 00:44
@wolfgangwalther
Copy link
Contributor

Right now you have 4 commits, but we can't merge like that. Please rebase your branch, so that you have three commits:

  • postgresqlPackages.pg_net: 0.8.0 -> 0.11.0
  • postgresqlPackages.pg_net: add samrose as maintainer (note it's fine to add yourself in this PR, I just meant it to be a separate commit)
  • postgresqlPackages.pg_net: nixfmt

Please also change the PR title accordingly (with the postgreslPackages prefix). I wasn't able to find this PR when just searching for "postgresql" the first time, it didn't show up. Also some of the CI depends on the commits' prefixes, IIRC.

@samrose samrose changed the title pg_net: 0.8.0 -> 0.11.0 postgreslPackages.pg_net: 0.8.0 -> 0.11.0 Nov 5, 2024
@samrose samrose changed the title postgreslPackages.pg_net: 0.8.0 -> 0.11.0 postgresqlPackages.pg_net: 0.8.0 -> 0.11.0 Nov 5, 2024
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for @wolfgangwalther's remarks the change looks good to me, thanks!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2024
@wolfgangwalther
Copy link
Contributor

This now needs a rebase to solve the expected conflicts after #344039 has reached master.

@samrose samrose closed this Nov 15, 2024
@samrose samrose deleted the pg_net branch November 15, 2024 10:45
@wolfgangwalther
Copy link
Contributor

ftr: I added the update of pg_net to #356283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants