Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posting: init at 2.3.0 #353386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions maintainers/maintainer-list.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11174,6 +11174,12 @@
github = "jordanisaacs";
githubId = 19742638;
};
jorikvanveen = {
email = "[email protected]";
github = "jorikvanveen";
githubId = 33939820;
name = "Jorik van Veen";
};
jorise = {
email = "[email protected]";
github = "JorisE";
Expand Down
50 changes: 50 additions & 0 deletions pkgs/by-name/po/posting/package.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
{
lib,
fetchFromGitHub,
python3Packages,
}:
let
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty let in?

in
python3Packages.buildPythonApplication rec {
pname = "posting";
version = "2.3.0";
pyproject = true;

src = fetchFromGitHub {
owner = "darrenburns";
repo = "posting";
rev = "refs/tags/${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to just use tag = version;

sha256 = "sha256-lL85gJxFw8/e8Js+UCE9VxBMcmWRUkHh8Cq5wTC93KA=";
};

pythonRelaxDeps = true;

nativeBuildInputs = [ python3Packages.hatchling ];

dependencies =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would make sense to put a with python3Packages; here

[
python3Packages.click
python3Packages.xdg-base-dirs
python3Packages.click-default-group
python3Packages.pyperclip
python3Packages.pyyaml
python3Packages.python-dotenv
python3Packages.watchfiles
python3Packages.pydantic
python3Packages.pydantic-settings
python3Packages.httpx
python3Packages.textual-autocomplete
python3Packages.textual
]
++ python3Packages.httpx.optional-dependencies.brotli
++ python3Packages.textual.optional-dependencies.syntax;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably include xorg.xdb so X resources themes can work


meta = {
description = "Modern API client that lives in your terminal";
mainProgram = "posting";
homepage = "https://posting.sh/";
license = lib.licenses.asl20;
maintainers = with lib.maintainers; [ jorikvanveen ];
platforms = lib.platforms.unix;
};
}
44 changes: 44 additions & 0 deletions pkgs/development/python-modules/textual-autocomplete/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{
lib,
python3,
fetchPypi,
poetry-core,
textual,
typing-extensions,
hatchling,
}:
python3.pkgs.buildPythonPackage rec {
pname = "textual_autocomplete";
version = "3.0.0a13";
pyproject = true;

# Alpha versions of this packages are only available on Pypi for some reason
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current latest alpha source code is available on the version-two branch

src = fetchPypi {
inherit pname version;
hash = "sha256-21pK6VbdfW3s5T9/aV6X8qt1gZ3Za4ocBk7Flms6sRM=";
};

nativeBuildInputs = [
poetry-core
hatchling
];

pythonRelaxDeps = true;

dependencies = [
textual
typing-extensions
];

Aleksanaa marked this conversation as resolved.
Show resolved Hide resolved
pythonImportsCheck = [
"textual"
"typing_extensions"
];

meta = {
description = "Python library that provides autocomplete capabilities to textual";
homepage = "https://pypi.org/project/textual-autocomplete";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ jorikvanveen ];
};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/python-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -16005,6 +16005,8 @@ self: super: with self; {

textual = callPackage ../development/python-modules/textual { };

textual-autocomplete = callPackage ../development/python-modules/textual-autocomplete { };

textual-dev = callPackage ../development/python-modules/textual-dev { };

textual-fastdatatable = callPackage ../development/python-modules/textual-fastdatatable { };
Expand Down