Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fider: init at 0.24.0 #353346

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fider: init at 0.24.0 #353346

wants to merge 2 commits into from

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Nov 3, 2024

Continuing the previous PR #313713 by @drupol.
Closes #313705.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 3, 2024
@niklaskorz niklaskorz force-pushed the init/fider branch 6 times, most recently from c91093d to c1fc831 Compare November 3, 2024 14:55
@niklaskorz
Copy link
Contributor Author

niklaskorz commented Nov 3, 2024

@drupol Package and module are functioning now, I'm running a test instance at https://fider.korz.dev/ (feel free to sign up and click around)

Do you still want to co-maintain the Fider package and module or shall I remove you from the maintainers lists?

Next steps would then be bringing the module options into shape for easier configuration and for setting up reverse proxies.

@drupol
Copy link
Contributor

drupol commented Nov 3, 2024

Excellent work, thanks for taking it over, I wonder what was the issue with my initial PR !

You can leave me co-maintainer, I don't mind.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 4, 2024
@ofborg ofborg bot requested a review from drupol November 4, 2024 03:37
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Nov 4, 2024
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Nov 4, 2024
@niklaskorz niklaskorz changed the title fider: init at 0.23.0 fider: init at 0.24.0 Jan 19, 2025
@niklaskorz niklaskorz force-pushed the init/fider branch 2 times, most recently from c710d4f to dc3dce5 Compare January 19, 2025 10:48
Co-authored-by: Niklas Korz <[email protected]>
@niklaskorz niklaskorz force-pushed the init/fider branch 2 times, most recently from a208896 to f78f98f Compare January 19, 2025 10:56
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jan 19, 2025
Co-authored-by: Niklas Korz <[email protected]>
@niklaskorz
Copy link
Contributor Author

niklaskorz commented Jan 19, 2025

Excellent work, thanks for taking it over, I wonder what was the issue with my initial PR !

The blocking issue you described in getfider/fider#1168 I was able to fix by performing the copy of etc in the installPhase and then patching out the runtime copy (see 0001-disable-etc-copy.patch).

You can leave me co-maintainer, I don't mind.

Great, thanks :)

Summary of changes from your PR:

  • refactored package to allow easy overrides of version, server, frontend, ...
  • fixed the etc copy issue
  • added example config to NixOS module options
  • added release notes

I think this is ready to go for the initial release. I'll add settings for configuring reverse proxies and for type-checked settings (instead of having to specify everything in environment / environmentFile) in a follow-up PR.

@niklaskorz niklaskorz marked this pull request as ready for review January 19, 2025 11:14
@niklaskorz
Copy link
Contributor Author

(running nixpkgs-review for package builds and NixOS tests atm, will post results when done)

pname = "${pname}-server";

patches = [
./0001-disable-etc-copy.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should add a comment explaining why the patch is needed, plus a link to the issue.

Copy link
Contributor Author

@niklaskorz niklaskorz Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually let me have another look at the copy mechanism, I went through the code again just now and wonder if there is a better solution than disabling it... (will report back later)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I’ll follow it.

@niklaskorz
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353346


aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • fider

x86_64-darwin

✅ 1 package built:
  • fider

aarch64-darwin

✅ 1 package built:
  • fider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: fider
3 participants