-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fider: init at 0.24.0 #353346
base: master
Are you sure you want to change the base?
fider: init at 0.24.0 #353346
Conversation
c91093d
to
c1fc831
Compare
@drupol Package and module are functioning now, I'm running a test instance at https://fider.korz.dev/ (feel free to sign up and click around) Do you still want to co-maintain the Fider package and module or shall I remove you from the Next steps would then be bringing the module options into shape for easier configuration and for setting up reverse proxies. |
Excellent work, thanks for taking it over, I wonder what was the issue with my initial PR ! You can leave me co-maintainer, I don't mind. |
c1fc831
to
28be368
Compare
c710d4f
to
dc3dce5
Compare
Co-authored-by: Niklas Korz <[email protected]>
a208896
to
f78f98f
Compare
Co-authored-by: Niklas Korz <[email protected]>
f78f98f
to
54e48b6
Compare
The blocking issue you described in getfider/fider#1168 I was able to fix by performing the copy of etc in the installPhase and then patching out the runtime copy (see
Great, thanks :) Summary of changes from your PR:
I think this is ready to go for the initial release. I'll add settings for configuring reverse proxies and for type-checked settings (instead of having to specify everything in |
(running nixpkgs-review for package builds and NixOS tests atm, will post results when done) |
pname = "${pname}-server"; | ||
|
||
patches = [ | ||
./0001-disable-etc-copy.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should add a comment explaining why the patch is needed, plus a link to the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually let me have another look at the copy mechanism, I went through the code again just now and wonder if there is a better solution than disabling it... (will report back later)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I’ll follow it.
|
Continuing the previous PR #313713 by @drupol.
Closes #313705.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.