manga-tui: 0.3.1 -> 0.4.0

[youwen5]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

---

There are issues with upstream when building in Nix (specifically, there's 2 tests that don't pass). I submitted a PR upstream to fix one of them but am not sure how to fix the other, so I just added a patch to delete it for the time being.

[youwen5]

PR got merged upstream so I'm just applying the commit as a patch until the next release.

[pbsbot]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353060

---

x86_64-linux

❌ 1 package failed to build:

• manga-tui

manga-tui> failures:
manga-tui>
manga-tui> ---- view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch stdout ----
manga-tui> thread 'view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch' panicked at src/backend/error_log.rs:44:64:
manga-tui> called `Result::unwrap()` on an `Err` value: Os { code: 17, kind: AlreadyExists, message: "File exists" }
manga-tui> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
manga-tui> thread 'view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch' panicked at src/view/pages/manga.rs:1872:14:
manga-tui> called `Result::unwrap()` on an `Err` value: Elapsed(())
manga-tui>
manga-tui>
manga-tui> failures:
manga-tui>     view::pages::manga::test::it_sends_event_chapter_bookmarked_failed_to_fetch

[youwen5]

This test seems flaky and non deterministic, it builds fine for me but seems to fail sometimes. I'm gonna open an issue upstream. Until then we can just patch the test out.

[isabelroses]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353060

---

x86_64-linux

✅ 1 package built:

• manga-tui

[pbsds]

Thank you and welcome to nixpkgs!

Now that you've added yourself to maintainer-list.nix you should in short time be invited to join the nixos/nixpkgs-maintainers group. That invite email will expire in a week. Joining the group will give you additional permissions in nixpkgs, like the ability to change labels on issues and pull requests.