Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox: do not use open-watcom-bin #352610

Merged

Conversation

FriedrichAltheide
Copy link
Contributor

  • virtualbox: do not use open-watcom-bin for now

hopefully fixing: #351413

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FriedrichAltheide
Copy link
Contributor Author

Closing in favour of #352609

@emilazy
Copy link
Member

emilazy commented Oct 31, 2024

We should still do both, as Open Watcom has licensing issues.

@emilazy
Copy link
Member

emilazy commented Oct 31, 2024

I’ve merged the other fix, but it’d be good to get this in since otherwise #352608 will stop VirtualBox and the OVA being built on Hydra.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built on x86_64-linux, thanks! Having to use pre‐built assembly sources is a bit unfortunate, but better than depending on a non‐Free compiler that we get as a binary blob.

BTW, it seems the meta.license is out of date – they’ve moved to GPL 3 with a linking exception for GPL 2 (sadly something we lack an elegant way of representing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants