Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] floorp: 11.19.1 -> 11.20.0 #352163

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[Backport release-24.05] floorp: 11.19.1 -> 11.20.0 #352163

merged 1 commit into from
Oct 31, 2024

Conversation

christoph-heiss
Copy link
Contributor

@christoph-heiss christoph-heiss commented Oct 29, 2024 •
edited
Loading

See also #352159.

Release notes: https://blog.ablaze.one/4556/2024-10-09/
Git changelog: Floorp-Projects/Floorp@v11.19.1...v11.20.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@christoph-heiss christoph-heiss added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 29, 2024
@christoph-heiss christoph-heiss mentioned this pull request Oct 29, 2024
Merged
13 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 29, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 31, 2024
@wegank wegank merged commit b6ab28c into NixOS:release-24.05 Oct 31, 2024
43 of 45 checks passed
@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352163

x86_64-linux

✅ 2 packages built:
  • floorp-unwrapped
  • floorp-unwrapped.debug

@christoph-heiss christoph-heiss deleted the backport-floorp-24-05 branch October 31, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@wegank wegank Awaiting requested review from wegank

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christoph-heiss @Scrumplex @SuperSandro2000 @wegank