Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mamba-cpp: init at 2.0.5 #352030

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mamba-cpp: init at 2.0.5 #352030

wants to merge 1 commit into from

Conversation

klchen0112
Copy link
Contributor

@klchen0112 klchen0112 commented Oct 29, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@klchen0112 klchen0112 force-pushed the mamba branch 2 times, most recently from 1cf7457 to 3355c6b Compare October 29, 2024 07:55
@klchen0112
Copy link
Contributor Author

except passthru on aarch64-darwin , other tests passed

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 9, 2024
@FliegendeWurst FliegendeWurst self-requested a review November 9, 2024 21:11
@FliegendeWurst FliegendeWurst removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 9, 2024
@FliegendeWurst
Copy link
Member

Second commit message should start with mamba-cpp (that is the package name)

@klchen0112 klchen0112 changed the title mamba: init at 2.0.2 mamba-cpp: init at 2.0.2 Nov 13, 2024
@klchen0112
Copy link
Contributor Author

@FliegendeWurst All check have passed.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 13, 2025
@FliegendeWurst FliegendeWurst changed the title mamba-cpp: init at 2.0.2 mamba-cpp: init at 2.0.5 Jan 13, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klchen0112 @FliegendeWurst @wegank