Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u3-tool: 0.3 -> 1.0 #351980

Merged
merged 3 commits into from
Nov 24, 2024
Merged

u3-tool: 0.3 -> 1.0 #351980

merged 3 commits into from
Nov 24, 2024

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Oct 28, 2024

Update u3-tool to latest version (2009 -> 2012).
Also move tool to by-name package structure.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 29, 2024
pkgs/by-name/u3/u3-tool/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/u3/u3-tool/package.nix Outdated Show resolved Hide resolved
@makefu makefu force-pushed the pkgs/u3-tool/update branch from aaba52e to 466c330 Compare November 2, 2024 22:08
@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 3, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
somehow only the version 0.3 is available in sourceforge
as 'download'. However in svn the final release
can be fetched. The same release is available
for direct download via the mirror://sourceforge url

the package now uses finalAttrs in favour of rec
@makefu makefu force-pushed the pkgs/u3-tool/update branch from 466c330 to 7496b4c Compare November 20, 2024 22:17
@jopejoe1 jopejoe1 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 20, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 22, 2024
@donovanglover donovanglover merged commit b14b105 into NixOS:master Nov 24, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants