Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.enaml: 0.17.0 -> 0.18.0 #351979

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python312Packages.enaml is: Declarative User Interfaces for Python

meta.homepage for python312Packages.enaml is: https://github.com/nucleic/enaml

meta.changelog for python312Packages.enaml is: https://github.com/nucleic/enaml/releases/tag/0.18.0

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.18.0 with grep in /nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0
  • found 0.18.0 in filename of file in /nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0

Rebuild report (if merged into master) (click to expand)
7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath

inkcut
inkscape-extensions.inkcut
python311Packages.enaml
python311Packages.enamlx
python312Packages.enaml
python312Packages.enamlx
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python312Packages.enaml https://github.com/r-ryantm/nixpkgs/archive/92cec8517391c42b2bf4f0c376aec84efcf4b0ad.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/92cec8517391c42b2bf4f0c376aec84efcf4b0ad#python312Packages.enaml

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0
ls -la /nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 11 packages built:
  • inkcut
  • inkcut.dist
  • inkscape-extensions.inkcut
  • python311Packages.enaml
  • python311Packages.enaml.dist
  • python311Packages.enamlx
  • python311Packages.enamlx.dist
  • python312Packages.enaml
  • python312Packages.enaml.dist
  • python312Packages.enamlx
  • python312Packages.enamlx.dist

Maintainer pings

cc @raboof for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inkcut no longer starts with this change:

2024-10-29 09:32:00,591 | ERROR   | inkcut | Traceback (most recent call last):
  File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/lib/python3.12/site-packages/inkcut/app.py", line 99, in main
    workbench.run()
  File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/lib/python3.12/site-packages/inkcut/core/workbench.py", line 161, in run
    ui = self.get_plugin('enaml.workbench.ui')
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/workbench.py", line 144, in get_plugin
    plugin = manifest.factory()
             ^^^^^^^^^^^^^^^^^^
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/ui_manifest.enaml", line 18, in ui_plugin_factory
    from .ui_plugin import UIPlugin
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/ui_plugin.py", line 26, in <module>
    from .workbench_window import WorkbenchWindow
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/core/import_hooks.py", line 147, in exec_module
    exec(code, module.__dict__)
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 16, in 
    def make_title(primary, workspace):
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 1, in WorkbenchWindow
    #------------------------------------------------------------------------------
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 35, in WorkbenchWindow
    objects << [w for w in [window_model.workspace.content] if w]
ValueError: invalid end_lineno, expected >= 1, got 0

Traceback (most recent call last):
  File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/bin/.inkcut-wrapped", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/lib/python3.12/site-packages/inkcut/app.py", line 99, in main
    workbench.run()
  File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/lib/python3.12/site-packages/inkcut/core/workbench.py", line 161, in run
    ui = self.get_plugin('enaml.workbench.ui')
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/workbench.py", line 144, in get_plugin
    plugin = manifest.factory()
             ^^^^^^^^^^^^^^^^^^
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/ui_manifest.enaml", line 18, in ui_plugin_factory
    from .ui_plugin import UIPlugin
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/ui_plugin.py", line 26, in <module>
    from .workbench_window import WorkbenchWindow
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/core/import_hooks.py", line 147, in exec_module
    exec(code, module.__dict__)
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 16, in 
    def make_title(primary, workspace):
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 1, in WorkbenchWindow
    #------------------------------------------------------------------------------
  File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 35, in WorkbenchWindow
    objects << [w for w in [window_model.workspace.content] if w]
ValueError: invalid end_lineno, expected >= 1, got 0

@raboof raboof force-pushed the auto-update/python312Packages.enaml branch from 92cec85 to 537b83d Compare October 31, 2024 16:34
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of nixos-unstable because that has the update of bytecode from 0.15.1 to 0.16.0 which fixes this issue.

With that this LGTM when CI agrees

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 31, 2024
@ofborg ofborg bot requested a review from raboof October 31, 2024 22:46
@wegank wegank added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Oct 31, 2024
@raboof raboof merged commit 49b7c22 into NixOS:master Nov 1, 2024
29 of 30 checks passed
@r-ryantm r-ryantm deleted the auto-update/python312Packages.enaml branch November 1, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants