-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.enaml: 0.17.0 -> 0.18.0 #351979
python312Packages.enaml: 0.17.0 -> 0.18.0 #351979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inkcut no longer starts with this change:
2024-10-29 09:32:00,591 | ERROR | inkcut | Traceback (most recent call last):
File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/lib/python3.12/site-packages/inkcut/app.py", line 99, in main
workbench.run()
File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/lib/python3.12/site-packages/inkcut/core/workbench.py", line 161, in run
ui = self.get_plugin('enaml.workbench.ui')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/workbench.py", line 144, in get_plugin
plugin = manifest.factory()
^^^^^^^^^^^^^^^^^^
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/ui_manifest.enaml", line 18, in ui_plugin_factory
from .ui_plugin import UIPlugin
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/ui_plugin.py", line 26, in <module>
from .workbench_window import WorkbenchWindow
File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/core/import_hooks.py", line 147, in exec_module
exec(code, module.__dict__)
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 16, in
def make_title(primary, workspace):
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 1, in WorkbenchWindow
#------------------------------------------------------------------------------
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 35, in WorkbenchWindow
objects << [w for w in [window_model.workspace.content] if w]
ValueError: invalid end_lineno, expected >= 1, got 0
Traceback (most recent call last):
File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/bin/.inkcut-wrapped", line 9, in <module>
sys.exit(main())
^^^^^^
File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/lib/python3.12/site-packages/inkcut/app.py", line 99, in main
workbench.run()
File "/nix/store/qyjrpynnjpr73hcqmyvr0gkwxrni7y8j-inkcut-2.1.5/lib/python3.12/site-packages/inkcut/core/workbench.py", line 161, in run
ui = self.get_plugin('enaml.workbench.ui')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/workbench.py", line 144, in get_plugin
plugin = manifest.factory()
^^^^^^^^^^^^^^^^^^
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/ui_manifest.enaml", line 18, in ui_plugin_factory
from .ui_plugin import UIPlugin
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/ui_plugin.py", line 26, in <module>
from .workbench_window import WorkbenchWindow
File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/core/import_hooks.py", line 147, in exec_module
exec(code, module.__dict__)
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 16, in
def make_title(primary, workspace):
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 1, in WorkbenchWindow
#------------------------------------------------------------------------------
File "/nix/store/f7246ka4bp99vsdplg7l4yxsdys3r3rx-python3.12-enaml-0.18.0/lib/python3.12/site-packages/enaml/workbench/ui/workbench_window.enaml", line 35, in WorkbenchWindow
objects << [w for w in [window_model.workspace.content] if w]
ValueError: invalid end_lineno, expected >= 1, got 0
92cec85
to
537b83d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on top of nixos-unstable because that has the update of bytecode from 0.15.1 to 0.16.0 which fixes this issue.
With that this LGTM when CI agrees
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.enaml is: Declarative User Interfaces for Python
meta.homepage for python312Packages.enaml is: https://github.com/nucleic/enaml
meta.changelog for python312Packages.enaml is: https://github.com/nucleic/enaml/releases/tag/0.18.0
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review
resultGenerated using
nixpkgs-review
.Command:
nixpkgs-review
x86_64-linux
✅ 11 packages built:
Maintainer pings
cc @raboof for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*
, you can comment@NixOS/nixpkgs-merge-bot merge
to automatically merge this update using thenixpkgs-merge-bot
.Add a 👍 reaction to pull requests you find important.