Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jellyfin: 10.9.11 -> 10.10.0 #351966

Merged
merged 3 commits into from
Nov 2, 2024
Merged

jellyfin: 10.9.11 -> 10.10.0 #351966

merged 3 commits into from
Nov 2, 2024

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 28, 2024

https://jellyfin.org/posts/jellyfin-release-10.10.0

fixes #351607
cc @Titaniumtown @justinas @justinkb

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@justinkb
Copy link
Contributor

looks good, I came to basically the same changes, except I didn't do your nice sha revision thing. is this gonna be backported to 24.05, for reference?

@Titaniumtown
Copy link
Contributor

Titaniumtown commented Oct 29, 2024

For me, it's getting stuck at "Installing dependencies", I've been waiting 35 minutes lol

jellyfin-web> building '/nix/store/ssvd3blgnnf6ylpxvcf6j0ikzk41lyjd-jellyfin-web-10.10.0.drv'
jellyfin-web> Running phase: unpackPhase
jellyfin-web> unpacking source archive /nix/store/08bnd5lxc4x8rh08261ra49krcl31a50-source
jellyfin-web> source root is source
jellyfin-web> Running phase: patchPhase
jellyfin-web> Executing npmConfigHook
jellyfin-web> Configuring npm
jellyfin-web> Validating consistency between /build/source/package-lock.json and /nix/store/8sdn3lpmpwzh4gpixi0g5rinwqy6ls7q-jellyfin-web-10.10.0-npm-deps/package-lock.json
jellyfin-web> Fixing lockfile
Installing dependencies

EDIT: It's now hung for approx ~8 hours :(

@dotlambda

This comment was marked as outdated.

@purcell
Copy link
Member

purcell commented Oct 29, 2024

The failure on x86_64-darwin is new, right? I don't see any indication that BlurHashSharp doesn't support MacOS now, so it's confusing.

@dotlambda
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351966


x86_64-linux

✅ 9 packages built:
  • jellyfin
  • jellyfin-ffmpeg
  • jellyfin-ffmpeg.bin
  • jellyfin-ffmpeg.data
  • jellyfin-ffmpeg.dev
  • jellyfin-ffmpeg.doc
  • jellyfin-ffmpeg.lib
  • jellyfin-ffmpeg.man
  • jellyfin-web

aarch64-linux

✅ 2 packages built:
  • jellyfin
  • jellyfin-web

x86_64-darwin

✅ 2 packages built:
  • jellyfin
  • jellyfin-web

aarch64-darwin

✅ 2 packages built:
  • jellyfin
  • jellyfin-web

@Titaniumtown
Copy link
Contributor

How are people able to get this to build? I can't get it to build at all :p

@K900
Copy link
Contributor

K900 commented Oct 30, 2024

Built and running fine on my aarch64 system.

@Titaniumtown
Copy link
Contributor

Yea I think my nix store is messed up :p oh well.

@Titaniumtown
Copy link
Contributor

Turns out my local build failure is due to a known kernel issue. Disregard my previous concern :P

@K900
Copy link
Contributor

K900 commented Nov 1, 2024

I'm going to merge later today if there are no objections.

@dotlambda dotlambda merged commit 14fc87c into NixOS:master Nov 2, 2024
29 of 30 checks passed
@dotlambda dotlambda deleted the jellyfin branch November 2, 2024 05:30
@Myaats

This comment was marked as outdated.

@wrocketdev
Copy link

Can confirm, jellyfin-ffmpeg-7.0.2-5 no building.

       > libavcodec/libxeve.c: In function 'get_conf':
       > libavcodec/libxeve.c:199:27: error: incompatible types when assigning to type 'XEVE_RATIONAL' {aka 'struct _XEVE_RATIONAL'} from type 'long int'
       >   199 |         cdsc->param.fps = lrintf(av_q2d(avctx->framerate));
       >       |                           ^~~~~~
       > libavcodec/libxeve.c: In function 'libxeve_encode':
       > libavcodec/libxeve.c:484:40: error: incompatible types when assigning to type 'int' from type 'XEVE_RATIONAL' {aka 'struct _XEVE_RATIONAL'}
       >   484 |                 avpkt->time_base.den = xectx->cdsc.param.fps;
       >       |                                        ^~~~~
       > make: *** [ffbuild/common.mak:82: libavcodec/libxeve.o] Error 1
       > make: *** Waiting for unfinished jobs....
       For full logs, run 'nix log /nix/store/n9vd6qaiyzkyc8jf09ikr07k3vm9wxs2-jellyfin-ffmpeg-7.0.2-5.drv'.
error: 1 dependencies of derivation '/nix/store/s13zkd4ln6pppk3za5hvl7iq47zk77pq-jellyfin-10.10.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/8qlyiriaqsblwya37zj2v4wwqccvbl5l-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/hqxkyqzi3p8ippfgcwcdb45wzd6896r6-nixos-system-serveur-24.11.20241102.7ffd9ae.drv' failed to build
┏━ 1 Errors: 
 ⋮ 
┃        > CC   libavcodec/libxevd.o
┃        > CC   libavcodec/libxeve.o
┃        > CC   libavcodec/libxvid.o
┃        > libavcodec/libxeve.c: In function 'get_conf':
┃        > libavcodec/libxeve.c:199:27: error: incompatible types when assigning to type 'XEVE_RATIONAL' {aka 'struct _XEVE_RATIONAL'} from type 'long int'
┃        >   199 |         cdsc->param.fps = lrintf(av_q2d(avctx->framerate));
┃        >       |                           ^~~~~~
┃        > libavcodec/libxeve.c: In function 'libxeve_encode':
┃        > libavcodec/libxeve.c:484:40: error: incompatible types when assigning to type 'int' from type 'XEVE_RATIONAL' {aka 'struct _XEVE_RATIONAL'}
┃        >   484 |                 avpkt->time_base.den = xectx->cdsc.param.fps;
┃        >       |                                        ^~~~~
┃        > make: *** [ffbuild/common.mak:82: libavcodec/libxeve.o] Error 1
┃        > make: *** Waiting for unfinished jobs....
┃        For full logs, run 'nix log /nix/store/n9vd6qaiyzkyc8jf09ikr07k3vm9wxs2-jellyfin-ffmpeg-7.0.2-5.drv'.

@K900
Copy link
Contributor

K900 commented Nov 3, 2024

Seems like it may have been broken by the staging merge?

@justinas
Copy link
Member

justinas commented Nov 3, 2024

Fixed since? Seems to build (and is cached) at b7b476a .

@WesfunOfficial
Copy link

looks like build is failing on my end
screenshot-2024-11-03-22-17-54

@NixOS NixOS locked as off-topic and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: Jellyfin 10.9.11 → 10.10.0
9 participants