Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

earbuds: init at 0.1.9-unstable-2024-06-28 #351860

Merged
merged 2 commits into from
Nov 7, 2024
Merged

earbuds: init at 0.1.9-unstable-2024-06-28 #351860

merged 2 commits into from
Nov 7, 2024

Conversation

griffi-gh
Copy link
Member

@griffi-gh griffi-gh commented Oct 28, 2024 •
edited
Loading

closes #351851

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 28, 2024
@griffi-gh griffi-gh marked this pull request as ready for review October 28, 2024 10:37
@FliegendeWurst FliegendeWurst added the 12. first-time contribution This PR is the author's first one; please be gentle! label Oct 28, 2024
FliegendeWurst
FliegendeWurst approved these changes Oct 28, 2024
View reviewed changes
pkgs/by-name/ea/earbuds/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 28, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 28, 2024
@nartsisss nartsisss added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 28, 2024
@griffi-gh griffi-gh requested a review from Aleksanaa October 29, 2024 11:03
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Oct 29, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351860

x86_64-linux

✅ 1 package built:
  • earbuds

aarch64-linux

✅ 1 package built:
  • earbuds

x86_64-darwin

aarch64-darwin

GaetanLepage
GaetanLepage approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you !
(theoretically, postInstall should go above nativeCheckInstallInputs, but this is not that important).

@GaetanLepage
Copy link
Contributor

Let's wait for ofborg and merge.

@nyabinary
Copy link
Contributor

Should probably update to the latest commit since it adds support for new buds and also upstream hasn't released a tagged ver in a long time :P.

@GaetanLepage
Copy link
Contributor

Should probably update to the latest commit since it adds support for new buds and also upstream hasn't released a tagged ver in a long time :P.

Why not. You could also kindly ask upstream to create a new tag. We never know, they might accept.

@griffi-gh
Copy link
Member Author

Updated to 0.1.9-unstable-2024-06-28

@griffi-gh griffi-gh changed the title earbuds: init at 0.1.9 earbuds: init at 0.1.9-unstable-2024-06-28 Nov 4, 2024
@griffi-gh
Copy link
Member Author

griffi-gh commented Nov 4, 2024 •
edited
Loading

  • It includes git dependencies, so i had to include the lock file and switch from cargoHash to cargoLock.
  • The master branch has a minor bug caused by clap dependency update, which causes the daemon to fail to auto-start if it's not already running due to wrong arguments in the start function. I submitted the patch upstream too.

Aleksanaa
Aleksanaa reviewed Nov 4, 2024
View reviewed changes
pkgs/by-name/ea/earbuds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ea/earbuds/package.nix Outdated Show resolved Hide resolved
@griffi-gh griffi-gh requested a review from Aleksanaa November 4, 2024 12:15
@griffi-gh
Copy link
Member Author

@GaetanLepage bump?

@Aleksanaa Aleksanaa merged commit 50f4b2d into NixOS:master Nov 7, 2024
33 of 34 checks passed
@griffi-gh griffi-gh self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartsisss nartsisss nartsisss approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@GaetanLepage GaetanLepage Awaiting requested review from GaetanLepage

Assignees

@griffi-gh griffi-gh

Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: earbuds
7 participants
@griffi-gh @GaetanLepage @nyabinary @FliegendeWurst @Aleksanaa @nartsisss @wegank