Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

veilid: 0.4.0 -> 0.4.1 #351270

Merged
merged 1 commit into from
Oct 28, 2024
Merged

veilid: 0.4.0 -> 0.4.1 #351270

merged 1 commit into from
Oct 28, 2024

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Oct 25, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ethnh
Copy link
Contributor

ethnh commented Oct 28, 2024

Thanks for this 🙇‍♂️ LGTM 👍

@qbit
Copy link
Contributor

qbit commented Oct 28, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351270


x86_64-linux

✅ 3 packages built:
  • veilid
  • veilid.dev
  • veilid.lib

@bbigras bbigras merged commit a9d1372 into NixOS:master Oct 28, 2024
38 of 39 checks passed
@bbigras bbigras deleted the push-yxmlwwmqtyol branch October 28, 2024 20:45
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-351270-to-release-24.05 origin/release-24.05
cd .worktree/backport-351270-to-release-24.05
git switch --create backport-351270-to-release-24.05
git cherry-pick -x 233eca36f8d2a85ea91c8b015ec699f8e32dcb0f

@bbigras
Copy link
Contributor Author

bbigras commented Oct 28, 2024

The backport failed because there's another one that needs to be merged first.

quoting myself:

We can't update Veilid >= 0.4.0 for 24.05 because of the rust version

so let's not worry about backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants