Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mautrix-signal: 0.7.1 -> 0.7.2 and fix media uploads #351247

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Oct 25, 2024

Changelog: https://github.com/mautrix/signal/releases/tag/v0.7.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@niklaskorz
Copy link
Contributor Author

Running succesfully on my own server, but unlike stated in mautrix/signal#564, it does not seem to fix the issue of not being able to send media.

@ofborg ofborg bot requested review from expipiplus1 and Ma27 October 25, 2024 21:09
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 25, 2024
@Enzime
Copy link
Member

Enzime commented Oct 27, 2024

The fix is not in a release yet, the recommendation from mautrix/signal#564 (comment) is to use main instead

@niklaskorz
Copy link
Contributor Author

niklaskorz commented Oct 27, 2024

The fix is not in a release yet, the recommendation from mautrix/signal#564 (comment) is to use main instead

Do you know which commit in particular fixed it? The usual procedure would then be to only pull in that commit / PR as a patch into nixpkgs until the next release.

Edit: I suppose it's mautrix/signal@b09995a, will try with that as a patch
Edit 2: Yup that was it, uploads now work again with this PR

@niklaskorz niklaskorz changed the title mautrix-signal: 0.7.1 -> 0.7.2 mautrix-signal: 0.7.1 -> 0.7.2 and fix media uploads Oct 27, 2024
@Ma27 Ma27 merged commit 68a12b3 into NixOS:master Oct 30, 2024
32 of 33 checks passed
@niklaskorz niklaskorz deleted the mautrix-signal-0.7.2 branch December 20, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants