-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tideways-cli: init at 1.2.2 #351192
Merged
Merged
tideways-cli: init at 1.2.2 #351192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
force-pushed
the
add-tideways-cli
branch
2 times, most recently
from
October 25, 2024 15:00
c5c92a3
to
c79d2ed
Compare
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
Oct 25, 2024
drupol
reviewed
Oct 25, 2024
''; | ||
|
||
passthru = { | ||
sources = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this in passthru
and not in a let...in
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise the common-updater-scripts
cannot find it.
error: attribute 'sources' in selection path 'tideways-cli.sources.x86_64-linux.drvAttrs.outputHash' not found
update-source-version: error: Couldn't evaluate old source hash from 'tideways-cli.sources.x86_64-linux'!
drupol
reviewed
Oct 25, 2024
shyim
force-pushed
the
add-tideways-cli
branch
3 times, most recently
from
October 26, 2024 07:15
326dadf
to
e872765
Compare
nix-owners
bot
requested review from
aanderse,
globin,
jtojnar,
Ma27 and
talyz
October 26, 2024 09:11
shyim
force-pushed
the
add-tideways-cli
branch
from
October 26, 2024 09:22
7014f13
to
1d56890
Compare
drupol
reviewed
Oct 28, 2024
shyim
force-pushed
the
add-tideways-cli
branch
from
October 28, 2024 18:18
1d56890
to
c40002e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: php
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Tideways CLI and Daemon for PHP Profiling.
The PR contains also a updateScript to the bot will create PR to update it
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.