Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tideways-cli: init at 1.2.2 #351192

Merged
merged 3 commits into from
Nov 20, 2024
Merged

tideways-cli: init at 1.2.2 #351192

merged 3 commits into from
Nov 20, 2024

Conversation

shyim
Copy link
Member

@shyim shyim commented Oct 25, 2024

Adds Tideways CLI and Daemon for PHP Profiling.

The PR contains also a updateScript to the bot will create PR to update it

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@shyim shyim force-pushed the add-tideways-cli branch 2 times, most recently from c5c92a3 to c79d2ed Compare October 25, 2024 15:00
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Oct 25, 2024
'';

passthru = {
sources = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in passthru and not in a let...in ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise the common-updater-scripts cannot find it.

error: attribute 'sources' in selection path 'tideways-cli.sources.x86_64-linux.drvAttrs.outputHash' not found
update-source-version: error: Couldn't evaluate old source hash from 'tideways-cli.sources.x86_64-linux'!

@shyim shyim force-pushed the add-tideways-cli branch 3 times, most recently from 326dadf to e872765 Compare October 26, 2024 07:15
@shyim shyim requested a review from drupol October 27, 2024 11:06
@domenkozar domenkozar merged commit d774cc7 into NixOS:master Nov 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants