Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.rtfde: fix build #351110

Merged
merged 1 commit into from
Oct 26, 2024
Merged

python312Packages.rtfde: fix build #351110

merged 1 commit into from
Oct 26, 2024

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Oct 25, 2024

I updated the disabledTests and added lark in pythonRelaxDeps.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol mentioned this pull request Oct 25, 2024
Merged
13 tasks
@ofborg ofborg bot requested a review from fabaff October 25, 2024 09:09
@drupol drupol requested a review from GaetanLepage October 25, 2024 19:31
@drupol
python312Packages.rtfde: fix build
bfd007c 
I updated the `disabledTests` and added `lark` in `pythonRelaxDeps`.
@drupol drupol force-pushed the push-ssvztkspoylw branch from 99c9ed2 to bfd007c Compare October 25, 2024 19:35
GaetanLepage
GaetanLepage approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GaetanLepage
GaetanLepage approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drupol drupol merged commit 193adc7 into NixOS:staging-next Oct 26, 2024
27 of 28 checks passed
@drupol drupol deleted the push-ssvztkspoylw branch October 26, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @GaetanLepage