-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mud: init at 1.0.1 #350895
mud: init at 1.0.1 #350895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
Also, the file should be named mud-git/package.nix
.
Adding the error: builder for '/nix/store/jm7hdgpl2rznvkasrz3ni1sicb63q2hp-mud-1.0.1.drv' failed with exit code 5;
last 25 log lines:
> Running phase: installCheckPhase
> Executing versionCheckPhase
> Successfully managed to find version 1.0.1 in the output of the command /nix/store/zazps9xjm5hnc70kjy0k8xdrrxkby30b-mud-1.0.1/bin/mud --version
> __
> __ _ __ _____/ /
> / ' \/ // / _ /
> /_/_/_/\_,_/\_,_/
> Jasur Sadikov <jasur@sadikoff.com>
> https://github.com/jasursadikov/mud
> 1.0.1
> Finished versionCheckPhase
> no Makefile or custom installCheckPhase, doing nothing
> Running phase: pythonCatchConflictsPhase
> Running phase: pythonRemoveBinBytecodePhase
> Running phase: pythonImportsCheckPhase
> Executing pythonImportsCheckPhase
> Running phase: pytestCheckPhase
> Executing pytestCheckPhase
> ============================= test session starts ==============================
> platform linux -- Python 3.12.6, pytest-8.3.2, pluggy-1.5.0
> rootdir: /build/source
> configfile: pyproject.toml
> collected 0 items
>
> ============================ no tests ran in 0.01s ============================= It builds just fine without |
Yes, the hook will fail is the package has no test which is the case for this one. |
When looking back at the github repo, I think that the package should indeed be named |
No problem, it's all done now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
|
According to ofborg, the version check fails on the darwin systems |
Yes, indeed. It tries to write in preCheck = ''
export HOME=$(mktemp -d)
''; ? |
I don't have a mac to test it on though |
I will be able to test don't worry. |
mud: update
Unfortunately it doesn't work. I have tried a few different things but none was working. |
|
Closes #350755
Add mudgit to nixpkgs. It is a multi repository git utility, used to manage multiple git-repositories simultaneously.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.