Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mud: init at 1.0.1 #350895

Merged
merged 1 commit into from
Oct 29, 2024
Merged

mud: init at 1.0.1 #350895

merged 1 commit into from
Oct 29, 2024

Conversation

genga898
Copy link
Contributor

Closes #350755

Add mudgit to nixpkgs. It is a multi repository git utility, used to manage multiple git-repositories simultaneously.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

Also, the file should be named mud-git/package.nix.

pkgs/by-name/mu/mudgit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/mudgit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/mudgit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/mudgit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/mudgit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/mudgit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/mudgit/package.nix Outdated Show resolved Hide resolved
@genga898
Copy link
Contributor Author

Adding the python3Packages.pytestCheckHook causes the build to fail with the following error:

error: builder for '/nix/store/jm7hdgpl2rznvkasrz3ni1sicb63q2hp-mud-1.0.1.drv' failed with exit code 5;
       last 25 log lines:
       > Running phase: installCheckPhase
       > Executing versionCheckPhase
       > Successfully managed to find version 1.0.1 in the output of the command /nix/store/zazps9xjm5hnc70kjy0k8xdrrxkby30b-mud-1.0.1/bin/mud --version
       >                  __
       >   __ _  __ _____/ /
       >  /  ' \/ // / _  /
       > /_/_/_/\_,_/\_,_/  
       > Jasur Sadikov <jasur@sadikoff.com>
       > https://github.com/jasursadikov/mud
       > 1.0.1
       > Finished versionCheckPhase
       > no Makefile or custom installCheckPhase, doing nothing
       > Running phase: pythonCatchConflictsPhase
       > Running phase: pythonRemoveBinBytecodePhase
       > Running phase: pythonImportsCheckPhase
       > Executing pythonImportsCheckPhase
       > Running phase: pytestCheckPhase
       > Executing pytestCheckPhase
       > ============================= test session starts ==============================
       > platform linux -- Python 3.12.6, pytest-8.3.2, pluggy-1.5.0
       > rootdir: /build/source
       > configfile: pyproject.toml
       > collected 0 items                                                              
       >
       > ============================ no tests ran in 0.01s =============================

It builds just fine without python3Packages.pytestCheckHook

@genga898 genga898 changed the title mudgit: init at 1.0.1 mud-git: init at 1.0.1 Oct 28, 2024
pkgs/by-name/mu/mud-git/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/mud-git/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mu/mud-git/package.nix Outdated Show resolved Hide resolved
@GaetanLepage
Copy link
Contributor

It builds just fine without python3Packages.pytestCheckHook

Yes, the hook will fail is the package has no test which is the case for this one.
Just get rid of it.

@GaetanLepage
Copy link
Contributor

When looking back at the github repo, I think that the package should indeed be named mud.
You have it right in pname.
Please, rename the file and the commit too.
(Sorry for the previous wrong attempt)

@genga898 genga898 changed the title mud-git: init at 1.0.1 mud: init at 1.0.1 Oct 29, 2024
@genga898
Copy link
Contributor Author

No problem, it's all done now

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350895


x86_64-linux

✅ 2 packages built:
  • mud
  • mud.dist

aarch64-linux

✅ 2 packages built:
  • mud
  • mud.dist

x86_64-darwin

❌ 2 packages failed to build:
  • mud
  • mud.dist

aarch64-darwin

❌ 2 packages failed to build:
  • mud
  • mud.dist

@genga898
Copy link
Contributor Author

According to ofborg, the version check fails on the darwin systems

@GaetanLepage
Copy link
Contributor

According to ofborg, the version check fails on the darwin systems

Yes, indeed. It tries to write in /var/empty.
Can you try adding

preCheck = ''
  export HOME=$(mktemp -d)
'';

?

@genga898
Copy link
Contributor Author

I don't have a mac to test it on though

@GaetanLepage
Copy link
Contributor

I don't have a mac to test it on though

I will be able to test don't worry.

@GaetanLepage
Copy link
Contributor

Unfortunately it doesn't work. I have tried a few different things but none was working.
I ended up disabling the check on darwin.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350895


x86_64-linux

✅ 2 packages built:
  • mud
  • mud.dist

aarch64-linux

✅ 2 packages built:
  • mud
  • mud.dist

x86_64-darwin

✅ 2 packages built:
  • mud
  • mud.dist

aarch64-darwin

✅ 2 packages built:
  • mud
  • mud.dist

@GaetanLepage GaetanLepage merged commit 6868113 into NixOS:master Oct 29, 2024
26 of 28 checks passed
@genga898 genga898 deleted the mudgit branch November 8, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: mud-git
3 participants