Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.pytest-ruff: init at 0.4.1 #350635

Merged
merged 1 commit into from
Oct 25, 2024
Merged

python312Packages.pytest-ruff: init at 0.4.1 #350635

merged 1 commit into from
Oct 25, 2024
+57 −0

Conversation

baloo
Copy link
Member

@baloo baloo commented Oct 23, 2024 •
edited
Loading

pytest-ruff is a util to run ruff along with pytest

Depends: #350654
See; #350608

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@baloo baloo mentioned this pull request Oct 23, 2024
Closed
@baloo baloo force-pushed the baloo/pytest-ruff/init branch from 0695fc8 to 2e6dd15 Compare October 23, 2024 04:40
@baloo baloo marked this pull request as draft October 23, 2024 04:40
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: testing Tooling for automated testing of packages and modules labels Oct 23, 2024
@nix-owners nix-owners bot requested review from mweinelt, natsukium and tfc October 23, 2024 04:41
@baloo baloo changed the title python312Pakcages.pytest-ruff: init at 0.4.1 python312Packages.pytest-ruff: init at 0.4.1 Oct 23, 2024
@baloo baloo force-pushed the baloo/pytest-ruff/init branch from 2e6dd15 to 08defd3 Compare October 23, 2024 04:46
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Oct 23, 2024
@baloo baloo force-pushed the baloo/pytest-ruff/init branch from 08defd3 to ad086f1 Compare October 23, 2024 07:24
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: testing Tooling for automated testing of packages and modules labels Oct 23, 2024
@l0b0 l0b0 removed their request for review October 23, 2024 19:26
@baloo baloo force-pushed the baloo/pytest-ruff/init branch from ad086f1 to 0edb57d Compare October 24, 2024 22:39
@baloo baloo mentioned this pull request Oct 24, 2024
Merged
13 tasks
@baloo baloo marked this pull request as ready for review October 25, 2024 15:58
@baloo baloo force-pushed the baloo/pytest-ruff/init branch from 0edb57d to 42e639c Compare October 25, 2024 16:02
@baloo baloo force-pushed the baloo/pytest-ruff/init branch from 42e639c to 9304de3 Compare October 25, 2024 16:20
@nix-owners nix-owners bot requested a review from natsukium October 25, 2024 16:21
@baloo baloo force-pushed the baloo/pytest-ruff/init branch from 9304de3 to f2c7f6b Compare October 25, 2024 16:30
GaetanLepage
GaetanLepage requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round of minor comments.

pkgs/development/python-modules/pytest-ruff/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytest-ruff/default.nix Outdated Show resolved Hide resolved
@baloo baloo force-pushed the baloo/pytest-ruff/init branch from f2c7f6b to 9e10e6c Compare October 25, 2024 17:22
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350635

x86_64-linux

✅ 4 packages built:
  • python311Packages.pytest-ruff
  • python311Packages.pytest-ruff.dist
  • python312Packages.pytest-ruff
  • python312Packages.pytest-ruff.dist

aarch64-linux

✅ 4 packages built:
  • python311Packages.pytest-ruff
  • python311Packages.pytest-ruff.dist
  • python312Packages.pytest-ruff
  • python312Packages.pytest-ruff.dist

x86_64-darwin

✅ 4 packages built:
  • python311Packages.pytest-ruff
  • python311Packages.pytest-ruff.dist
  • python312Packages.pytest-ruff
  • python312Packages.pytest-ruff.dist

aarch64-darwin

✅ 4 packages built:
  • python311Packages.pytest-ruff
  • python311Packages.pytest-ruff.dist
  • python312Packages.pytest-ruff
  • python312Packages.pytest-ruff.dist

@baloo baloo force-pushed the baloo/pytest-ruff/init branch from 9e10e6c to df42b1b Compare October 25, 2024 17:34
GaetanLepage
GaetanLepage approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Let's wait for ofborg.

@baloo
Copy link
Member Author

baloo commented Oct 25, 2024

@GaetanLepage ofborg came back. I think the backlog on darwin is a couple of days long, any chance we could merge before that? You already checked it

@GaetanLepage
Copy link
Contributor

@GaetanLepage ofborg came back. I think the backlog on darwin is a couple of days long, any chance we could merge before that? You already checked it

Yes, I wanted to be sure that the eval succeeded.

@GaetanLepage GaetanLepage merged commit 19653b2 into NixOS:master Oct 25, 2024
30 of 31 checks passed
@baloo baloo deleted the baloo/pytest-ruff/init branch October 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baloo @GaetanLepage