Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grap: fix build #350401

Merged
merged 3 commits into from
Oct 29, 2024
Merged

grap: fix build #350401

merged 3 commits into from
Oct 29, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Oct 22, 2024

https://hydra.nixos.org/build/274975545/nixlog/1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from s1341 October 22, 2024 09:03
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 22, 2024
@pbsds
Copy link
Member

pbsds commented Oct 25, 2024

why both python and python3? this strikes me as unintentional

@Bot-wxt1221
Copy link
Member Author

@pbsds Done.

@Bot-wxt1221 Bot-wxt1221 force-pushed the grap branch 2 times, most recently from c0328c8 to 6b1c0e6 Compare October 27, 2024 14:44
@Bot-wxt1221 Bot-wxt1221 force-pushed the grap branch 2 times, most recently from f68b90a to be9321b Compare October 28, 2024 12:26
@Aleksanaa Aleksanaa merged commit 78e2ce1 into NixOS:master Oct 29, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants