Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nagstamon: 3.14.0 -> 3.16.2 #349714

Merged
merged 3 commits into from
Nov 29, 2024
Merged

nagstamon: 3.14.0 -> 3.16.2 #349714

merged 3 commits into from
Nov 29, 2024

Conversation

liberodark
Copy link
Contributor

@liberodark liberodark commented Oct 19, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@liberodark liberodark force-pushed the nagstamon_316 branch 4 times, most recently from 1dafaf3 to 0b508f8 Compare October 19, 2024 07:44
@liberodark liberodark marked this pull request as draft October 19, 2024 07:45
@liberodark liberodark force-pushed the nagstamon_316 branch 6 times, most recently from 47f6780 to 66ca21a Compare October 19, 2024 08:18
@liberodark liberodark mentioned this pull request Oct 19, 2024
Closed
13 tasks
@liberodark liberodark force-pushed the nagstamon_316 branch 3 times, most recently from 4c8f383 to 2e2743a Compare October 19, 2024 08:37
@liberodark liberodark marked this pull request as ready for review October 19, 2024 08:41
@ofborg ofborg bot requested a review from pSub October 19, 2024 09:51
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 19, 2024
@liberodark liberodark force-pushed the nagstamon_316 branch 3 times, most recently from efca017 to 48338f6 Compare November 15, 2024 11:06
@liberodark liberodark changed the title nagstamon: 3.14.0 > 3.16.0 nagstamon: 3.14.0 > 3.16.2 Nov 15, 2024
Artturin
Artturin requested changes Nov 15, 2024
View reviewed changes
pkgs/tools/misc/nagstamon/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/nagstamon/default.nix Outdated Show resolved Hide resolved
GaetanLepage and others added 2 commits November 22, 2024 00:31
@GaetanLepage @liberodark
nagstamon: move to by-name
250ac96 
Co-authored-by: liberodark <[email protected]>
@GaetanLepage @liberodark
nagstamon: format
697286b 
Co-authored-by: liberodark <[email protected]>
@GaetanLepage GaetanLepage force-pushed the nagstamon_316 branch 2 times, most recently from decd9e8 to 0481fa5 Compare November 21, 2024 23:37
@GaetanLepage
Copy link
Contributor

I was not able to launch the application successfully on wayland:

❯ /nix/store/vd1d202vlfxhagxsx4hh6pfwlmafzd5i-nagstamon-3.16.2/bin/nagstamon.py 
[Errno 2] No such file or directory: '/home/gaetan/.nagstamon/nagstamon.pid'
qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: linuxfb, xcb, minimal, offscreen, minimalegl, vkkhrdisplay, vnc, eglfs.

fish: Job 1, '/nix/store/vd1d202vlfxhagxsx4hh…' terminated by signal SIGABRT (Abort)

@liberodark
Copy link
Contributor Author

liberodark commented Nov 21, 2024 •
edited
Loading

Hi,

I dont have wayland sorry but i think this can be fixed.

With

buildInputs = [
    qt6Packages.qtmultimedia
    qt6Packages.qtbase
    qt6Packages.qtsvg
    qt6Packages.qtwayland  # Add This
  ];

Best Regards

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349714

x86_64-linux

✅ 2 packages built:
  • nagstamon
  • nagstamon.dist

aarch64-linux

✅ 2 packages built:
  • nagstamon
  • nagstamon.dist

x86_64-darwin

❌ 2 packages failed to build:
  • nagstamon
  • nagstamon.dist

aarch64-darwin

❌ 2 packages failed to build:
  • nagstamon
  • nagstamon.dist

@GaetanLepage
Copy link
Contributor

Fails on darwin with

Executing setuptoolsBuildPhase
Traceback (most recent call last):
  File "/private/tmp/nix-build-nagstamon-3.16.2.drv-0/source/nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 162, in <module>
    bdist_rpm=bdist_rpm_options)
              ^^^^^^^^^^^^^^^^^
NameError: name 'bdist_rpm_options' is not defined. Did you mean: 'bdist_mac_options'?

@liberodark
Copy link
Contributor Author

Yes but have disable darwin plateform.

@liberodark
Copy link
Contributor Author 

meta = {
    description = "Status monitor for the desktop";
    homepage = "https://nagstamon.de/";
    changelog = "https://github.com/HenriWahl/Nagstamon/releases/tag/v${version}";
    license = lib.licenses.gpl2Plus;
    maintainers = with lib.maintainers; [
      pSub
      liberodark
    ];
    mainProgram = "nagstamon.py";
    badPlatforms = platforms.darwin; # Here
  };
}

Strangely that is not visible in the PR actually.

@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Nov 22, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349714

x86_64-linux

✅ 2 packages built:
  • nagstamon
  • nagstamon.dist

aarch64-linux

✅ 2 packages built:
  • nagstamon
  • nagstamon.dist

x86_64-darwin

aarch64-darwin

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Nov 23, 2024
@GaetanLepage
Copy link
Contributor

@Artturin could you please have another look at this PR ? It is good to go as far as I am concerned.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349714

x86_64-linux

✅ 2 packages built:
  • nagstamon
  • nagstamon.dist

aarch64-linux

✅ 2 packages built:
  • nagstamon
  • nagstamon.dist

x86_64-darwin

aarch64-darwin

@GaetanLepage
Copy link
Contributor

cc @Artturin for final review

@Artturin Artturin merged commit 2c7123c into NixOS:master Nov 29, 2024
33 of 34 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

@khaneliman khaneliman khaneliman left review comments

@Artturin Artturin Artturin approved these changes

@jwillikers jwillikers jwillikers approved these changes

@pSub pSub Awaiting requested review from pSub

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@liberodark @GaetanLepage @khaneliman @SuperSandro2000 @FliegendeWurst @jwillikers @Artturin @wegank