Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nagiosPlugins.openbsd_snmp3_check: init at 0.55 #349598

Merged
merged 1 commit into from
Oct 30, 2024
Merged

nagiosPlugins.openbsd_snmp3_check: init at 0.55 #349598

merged 1 commit into from
Oct 30, 2024

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Oct 18, 2024 •
edited
Loading

openbsd_snmp3_check is an Icinga / Nagios SNMP v3 check plugin for OpenBSD systems state monitoring.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 18, 2024
@jwillikers jwillikers force-pushed the add-openbsd_snmp3_check branch from 2847bf6 to afc764b Compare October 19, 2024 11:39
@jwillikers jwillikers force-pushed the add-openbsd_snmp3_check branch from afc764b to 3abfe7e Compare October 28, 2024 21:40
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 29, 2024
@anthonyroussel anthonyroussel added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 29, 2024
@anthonyroussel
Copy link
Member

anthonyroussel commented Oct 29, 2024 •
edited
Loading

@ofborg build nagiosPlugins.openbsd_snmp3_check nagiosPlugins.openbsd_snmp3_check.tests

@jwillikers jwillikers marked this pull request as draft October 29, 2024 19:47
@jwillikers jwillikers force-pushed the add-openbsd_snmp3_check branch from 9871266 to 217adf4 Compare October 29, 2024 19:48
@jwillikers jwillikers marked this pull request as ready for review October 29, 2024 19:50
@jwillikers
Copy link
Contributor Author

I rebased to fix a merge conflict.

@jwillikers jwillikers force-pushed the add-openbsd_snmp3_check branch from 217adf4 to 4d0b3e4 Compare October 29, 2024 20:43
@jwillikers jwillikers force-pushed the add-openbsd_snmp3_check branch from 4d0b3e4 to 12f09fa Compare October 29, 2024 20:45
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 30, 2024
anthonyroussel
anthonyroussel approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@anthonyroussel anthonyroussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349598

x86_64-linux

✅ 1 package built:
  • nagiosPlugins.openbsd_snmp3_check

aarch64-darwin

✅ 1 package built:
  • nagiosPlugins.openbsd_snmp3_check

@anthonyroussel anthonyroussel merged commit efe481b into NixOS:master Oct 30, 2024
24 checks passed
@anthonyroussel anthonyroussel changed the title openbsd_snmp3_check: init at 0.55 nagiosPlugins.openbsd_snmp3_check: init at 0.55 Oct 30, 2024
@jwillikers jwillikers deleted the add-openbsd_snmp3_check branch October 30, 2024 22:05
@jwillikers
Copy link
Contributor Author

@anthonyroussel Thanks for all the help!

frederictobiasc pushed a commit to frederictobiasc/nixpkgs that referenced this pull request Nov 9, 2024
@jwillikers @frederictobiasc
nagiosPlugins.openbsd_snmp3_check: init at 0.55
92458b0 
NixOS#349598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyroussel anthonyroussel anthonyroussel approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwillikers @anthonyroussel