Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitbutler: 0.12.16 -> 0.13.2 #347819

Closed
wants to merge 1 commit into from
Closed

Conversation

Daholli
Copy link
Contributor

@Daholli Daholli commented Oct 10, 2024

https://github.com/gitbutlerapp/gitbutler/releases/tag/release%2F0.13.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Daholli
Copy link
Contributor Author

Daholli commented Oct 11, 2024

@getchoo @techknowlogick I might need some help with this one, getting some build errors that I don't understand

building '/nix/store/l7cql4iy503yh5s0fh8vf4m2h04f5ai2-cargo-vendor-dir.drv'...
ln: failed to create symbolic link '/nix/store/l66xlgix7nfdv9p3sx3ck1qmyswyy8m7-cargo-vendor-dir/gix-attributes-0.22.5/akqzgppwk6adz7z32y3mhcm6fydlz9s7-gix-attributes-0.22.5': Permission denied
error: builder for '/nix/store/l7cql4iy503yh5s0fh8vf4m2h04f5ai2-cargo-vendor-dir.drv' failed with exit code 1;
       last 1 log lines:
       > ln: failed to create symbolic link '/nix/store/l66xlgix7nfdv9p3sx3ck1qmyswyy8m7-cargo-vendor-dir/gix-attributes-0.22.5/akqzgppwk6adz7z32y3mhcm6fydlz9s7-gix-attributes-0.22.5': Permission denied
       For full logs, run 'nix log /nix/store/l7cql4iy503yh5s0fh8vf4m2h04f5ai2-cargo-vendor-dir.drv'.
error: 1 dependencies of derivation '/nix/store/zc2qxzysj23f7ny4s4a7qa0309iv9yrq-gitbutler-0.13.0.drv' failed to build

heading to bed now, but would appreciate if you guys could give some idea where I should look

@getchoo
Copy link
Member

getchoo commented Oct 11, 2024

It's #183344. This is the main reason the package hasn't been updated

Sometimes you are able to dedup these by patching, but I wasn't able to here last time I tried. We may need to wait on #282798

@tomodachi94
Copy link
Member

tomodachi94 commented Oct 12, 2024

Closes #335875.

@Daholli Daholli closed this Oct 18, 2024
@Daholli Daholli reopened this Oct 18, 2024
@Daholli Daholli changed the title gitbutler: 0.12.16 -> 0.13.0 gitbutler: 0.12.16 -> 0.13.2 Oct 18, 2024
@Rots
Copy link

Rots commented Nov 4, 2024

note that there are newer 0.13.x out already

@getchoo getchoo mentioned this pull request Nov 12, 2024
13 tasks
@jtojnar jtojnar closed this Dec 29, 2024
@jtojnar
Copy link
Member

jtojnar commented Dec 29, 2024

Superseded by #355366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants