linkding: init at 1.36.0

[l0b0]

Description of changes

From the project:

Self-hosted bookmark manager that is designed be to be minimal, fast, and easy to set up using Docker.

Closes #341665.

FYI @sissbruecker

TODO: Figure out how to run django-registration tests. I tried with

  checkPhase = let
    checkPython = python.withPackages(_: nativeCheckInputs);
  in ''
    runHook preCheck

    ${lib.getExe checkPython} -m nox \
        --no-install \
        --non-interactive \
        --python=${checkPython.pythonVersion} \
        --session="tests_with_coverage(python='${checkPython.pythonVersion}', django='${lib.versions.majorMinor django.version}')"

    runHook postCheck
  '';

I also tried --no-venv, to no avail. It refuses to use the existing Python and installed packages.

I also tried

  checkPhase = let
    checkPython = python.withPackages (ps: [ps.django ps.nox]);
  in ''
      runHook preCheck

      mkdir .nox
      ${lib.getExe checkPython} -m venv --system-site-packages .nox/tests_with_coverage-python-3-12-django-4-2
      . .nox/tests_with_coverage-python-3-12-django-4-2/bin/activate
      python -m nox \
          --no-install \
          --non-interactive \
          --envdir=.nox \
          --python=${checkPython.pythonVersion} \
          --reuse-venv=always \
          --session="tests_with_coverage(python='${checkPython.pythonVersion}', django='${lib.versions.majorMinor django.version}')"

      runHook postCheck
    '';

to create and activate a virtualenv with Django and nox during the build, but despite --system-site-packages python doesn't know about the nox module.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[trzpiot]

I can take over the review for aarch64-darwin as soon as the PR is ready. 🙂

[l0b0]

I can take over the review for aarch64-darwin as soon as the PR is ready. 🙂

Thanks! I can't see you in the list of possible reviewers, but feel free to look into aarch64-darwin support.

[drupol]

Hi!

The diff LGTM, except a few nits.

The PR must contain 2 commits ad minima:

• 1 commit to add the package: linkding: init at 1.36.0
• 1 commit to add the NixOS service: nixos/linkding: init (please verify in the contributor guide documentation how to format commit log messages correctly, I may be wrong here)

Since you're adding a new NixOS service, a release note entry must be added too.

[l0b0]

Update: Got a bit further; any other tests/improvements you'd like to see?