openssl: use makeBinaryWrapper instead of makeShellWrapper #340951
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes openssl to use makeBinaryWrapper since makeWrapper uses non-overridable runtimeShell that causes infinite recursion. That is, fetchurl in pkgs/top-level/all-packages.nix is bootstrapped by overriding dependencies to use stdenv.fetchurlBoot.
philiptaron
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Result of nixpkgs-review pr 340951 -p openssl -p openssl_3 -p openssl_3_2 -p openssl_3_3 run on x86_64-linux 1
18 packages built:
- openssl
- openssl.bin (openssl.bin.bin ,openssl.bin.debug ,openssl.bin.dev ,openssl.bin.doc ,openssl.bin.man)
- openssl.debug (openssl.debug.bin ,openssl.debug.debug ,openssl.debug.dev ,openssl.debug.doc ,openssl.debug.man)
- openssl.dev (openssl.dev.bin ,openssl.dev.debug ,openssl.dev.dev ,openssl.dev.doc ,openssl.dev.man)
- openssl.doc (openssl.doc.bin ,openssl.doc.debug ,openssl.doc.dev ,openssl.doc.doc ,openssl.doc.man)
- openssl.man (openssl.man.bin ,openssl.man.debug ,openssl.man.dev ,openssl.man.doc ,openssl.man.man)
- openssl_3_2
- openssl_3_2.bin (openssl_3_2.bin.bin ,openssl_3_2.bin.debug ,openssl_3_2.bin.dev ,openssl_3_2.bin.doc ,openssl_3_2.bin.man)
- openssl_3_2.debug (openssl_3_2.debug.bin ,openssl_3_2.debug.debug ,openssl_3_2.debug.dev ,openssl_3_2.debug.doc ,openssl_3_2.debug.man)
- openssl_3_2.dev (openssl_3_2.dev.bin ,openssl_3_2.dev.debug ,openssl_3_2.dev.dev ,openssl_3_2.dev.doc ,openssl_3_2.dev.man)
- openssl_3_2.doc (openssl_3_2.doc.bin ,openssl_3_2.doc.debug ,openssl_3_2.doc.dev ,openssl_3_2.doc.doc ,openssl_3_2.doc.man)
- openssl_3_2.man (openssl_3_2.man.bin ,openssl_3_2.man.debug ,openssl_3_2.man.dev ,openssl_3_2.man.doc ,openssl_3_2.man.man)
- openssl_3_3
- openssl_3_3.bin (openssl_3_3.bin.bin ,openssl_3_3.bin.debug ,openssl_3_3.bin.dev ,openssl_3_3.bin.doc ,openssl_3_3.bin.man)
- openssl_3_3.debug (openssl_3_3.debug.bin ,openssl_3_3.debug.debug ,openssl_3_3.debug.dev ,openssl_3_3.debug.doc ,openssl_3_3.debug.man)
- openssl_3_3.dev (openssl_3_3.dev.bin ,openssl_3_3.dev.debug ,openssl_3_3.dev.dev ,openssl_3_3.dev.doc ,openssl_3_3.dev.man)
- openssl_3_3.doc (openssl_3_3.doc.bin ,openssl_3_3.doc.debug ,openssl_3_3.doc.dev ,openssl_3_3.doc.doc ,openssl_3_3.doc.man)
- openssl_3_3.man (openssl_3_3.man.bin ,openssl_3_3.man.debug ,openssl_3_3.man.dev ,openssl_3_3.man.doc ,openssl_3_3.man.man)
thillux
approved these changes
Sep 11, 2024
tie
added
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This changes openssl to use makeBinaryWrapper since makeWrapper uses non-overridable runtimeShell that causes infinite recursion. That is, fetchurl in pkgs/top-level/all-packages.nix is bootstrapped by overriding dependencies to use stdenv.fetchurlBoot.
Split from #337961
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.