Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/telegraf: make sure ping executable is available when trying to ping #338673

Merged
merged 1 commit into from
Aug 31, 2024
Merged

nixos/telegraf: make sure ping executable is available when trying to ping #338673

merged 1 commit into from
Aug 31, 2024
+9 −1

Conversation

enolan
Copy link
Contributor

@enolan enolan commented Aug 31, 2024

Description of changes

Telegraf needs ping to be in its PATH otherwise it can't ping. This commit adds it to the PATH of the service, conditional on one of the inputs being a ping task. I also modified the module test to try pinging.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@enolan
nixos/telegraf: make sure ping executable is available when trying to…
934a337 
… ping

We need ping to be in PATH of the service otherwise it can't ping. This commit
adds it, conditional on one of the inputs being a ping task.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 31, 2024
@Artturin
Copy link
Member

@ofborg build nixosTests.telegraf

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 31, 2024
@Artturin Artturin merged commit 9ef8a9c into NixOS:master Aug 31, 2024
27 of 29 checks passed
@enolan enolan mentioned this pull request Aug 31, 2024
Closed
13 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Sep 1, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enolan @Artturin