python312Packages.libcst: move tests to passthru.tests #338508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
dotlambda
force-pushed
the
python3Packages.libcst
branch
2 times, most recently
from
a8e23c4 to
a071d1d
Compare
| hypothesis | ||
| lark | ||
| libcst | ||
| ]; | ||
|
|
||
| nativeCheckInputs = [ | ||
| black |
There was a problem hiding this comment.
We don't want to rely on linting tools like black.
There was a problem hiding this comment.
It's not used for linting hypothesmith's code. It's used to lint the code generated by it afaict.
That resolves their circular dependency on hypothesmith and ufmt.
dotlambda
force-pushed
the
python3Packages.libcst
branch
from
a071d1d to
0e0552e
Compare
|
Result of 2 packages marked as broken and skipped:
28 packages failed to build:
413 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.