Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbctl: 0.14 -> 0.16 #332560

Merged
merged 4 commits into from
Dec 6, 2024
Merged

sbctl: 0.14 -> 0.16 #332560

merged 4 commits into from
Dec 6, 2024

Conversation

Scrumplex
Copy link
Member

Description of changes

Foxboron/sbctl@0.14...0.15.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from RaitoBezarius August 5, 2024 21:13
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 5, 2024
@NickCao
Copy link
Member

NickCao commented Aug 6, 2024

Please check if there are any changes need to be done on lanzaboote side.

@Scrumplex
Copy link
Member Author

I ran the tests from lanzaboote with the sbctl version from this PR with no errors.

@oluceps
Copy link
Member

oluceps commented Oct 27, 2024

0.16 released.

@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Nov 8, 2024
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex Scrumplex changed the title sbctl: 0.14 -> 0.15.4 sbctl: 0.14 -> 0.16 Nov 9, 2024
@Scrumplex
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 332560


x86_64-linux

✅ 1 package built:
  • sbctl

aarch64-linux

✅ 1 package built:
  • sbctl

aarch64-darwin

@JohnRTitor JohnRTitor removed the awaiting_changes (old Marvin label, do not use) label Dec 6, 2024
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a few sbctl commands from this PR. Looks okay, merging

There seems be a breaking change with the configuration format.

old configuration detected. Please use `sbctl setup --migrate`

Nothing Lanzaboote can't adapt with.

@JohnRTitor JohnRTitor merged commit 9ff1494 into NixOS:master Dec 6, 2024
33 checks passed
@MithicSpirit
Copy link
Contributor

It would probably be good to add release notes since migrating sbctl to the new configuration layout makes it break lanzaboote configs, as per nix-community/lanzaboote#413. It's not hard to fix, but does require manual intervention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants