Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] pyhton3Packages.databricks-sql-connector: Fix broken #331732

Conversation

kfollesdal
Copy link
Contributor

@kfollesdal kfollesdal commented Aug 2, 2024

Description of changes

The package pyhton3Packages.databricks-sql-connector is broken and are marked as broken in nixos-24.05. The problem is fixed by upgrading to 3.3.0 from 3.1.0. Since the package is broken in nixos-24.05 I think it's reasonable to accept update of package to fix it.

This PR is a backport of #329134

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kfollesdal
Copy link
Contributor Author

Result of nixpkgs-review pr 331732 run on x86_64-linux 1

2 packages failed to build:
  • databricks-sql-cli
  • databricks-sql-cli.dist
2 packages built:
  • python311Packages.databricks-sql-connector
  • python311Packages.databricks-sql-connector.dist

@kfollesdal kfollesdal force-pushed the kfollesdal/24.05-fix-broken-databricks-connector branch from 8f0ae70 to d9fd652 Compare August 7, 2024 12:49
@kfollesdal
Copy link
Contributor Author

Result of nixpkgs-review pr 331732 run on x86_64-linux 1

4 packages built:
  • databricks-sql-cli
  • databricks-sql-cli.dist
  • python311Packages.databricks-sql-connector
  • python311Packages.databricks-sql-connector.dist

@kfollesdal kfollesdal marked this pull request as ready for review August 7, 2024 13:41
@kfollesdal kfollesdal changed the title [Backport release-24.05] pyhton3Packages.databricks-sql-connector: Fix broken, 3.1.0 -> 3.3.0 [Backport release-24.05] pyhton3Packages.databricks-sql-connector: Fix broken Aug 27, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4471

@kfollesdal kfollesdal added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 28, 2024
@Artturin Artturin merged commit 9b9516e into NixOS:release-24.05 Oct 28, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants