wl-screenrec: 0.1.3 -> 0.1.4-unstable-2024-07-28 #331628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
|
For some reason, when I applied this and tried to build: |
Includes support for FFmpeg 7. We can’t use the release tag because of a Cargo build issue; see <russelltg/wl-screenrec#77>. Hopefully there’ll be a new release tag soon. Diff: <russelltg/wl-screenrec@v0.1.3...b817acc>
emilazy
force-pushed
the
push-plukoopowzmx
branch
from
4a1eb53 to
d9b57ba
Compare
|
Uh, oops. I suspect I forgot to update the Cargo hash at some point when juggling versions, because I get the same hash if I clear it out. Try now? |
colemickens
approved these changes
Aug 2, 2024
|
Okay, pulled it back locally and gave it a quick test. Seems to work better than I remember, nice! Will merge. |
|
@ofborg eval |
|
okay clearly idk what I'm doing, I feel like I should wait for ofborg to eval and kick builds, but idk why it's not going. |
|
It’s just really slow these days. No rush, though – I didn’t actually test this out locally either, I’m just here to remove |
|
lol ofborg, I already approved! Looks like it's just waiting on darwin, I'm going to merge it. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Includes support for FFmpeg 7. We can’t use the release tag because of a Cargo build issue; see russelltg/wl-screenrec#77. Hopefully there’ll be a new release tag soon.
Diff: russelltg/wl-screenrec@v0.1.3...b817acc
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.