Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pylibjpeg-libjpeg: enable tests #330028

Merged

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jul 25, 2024

Description of changes

Routine update with Minor refactor and enabling tests.

Note that the pydicom-related tests are skipped even though pydicom is present seemingly because the test for pydicom checks for the presence of as-yet-unreleased pydicom 3.x APIs. Still better than the current situation, though. [master has updated to pydicom 3.x]

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bcdarwin bcdarwin force-pushed the update-python3-pylibjpeg-libjpeg branch 2 times, most recently from b2c205a to ec007fe Compare July 25, 2024 22:59
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 26, 2024
@Aleksanaa
Copy link
Member

@ofborg build python312Packages.pylibjpeg-libjpeg

@bcdarwin bcdarwin requested a review from Aleksanaa July 31, 2024 16:42
@bcdarwin
Copy link
Member Author

@ofborg build python312Packages.pylibjpeg-libjpeg

@bcdarwin
Copy link
Member Author

bcdarwin commented Nov 12, 2024

@Aleksanaa can this get merged? I fixed the previous gdcm build failure on Darwin in another PR but there's now a new Darwin-specific error in that dependency.

@Aleksanaa
Copy link
Member

I fixed the previous gdcm build failure on Darwin in another PR but there's now a new Darwin-specific error in that dependency.

So was it finally resolved? I think we can temporarily not enable test before solving the problem.

@bcdarwin bcdarwin force-pushed the update-python3-pylibjpeg-libjpeg branch from ec007fe to b4f46cd Compare November 13, 2024 01:45
@bcdarwin
Copy link
Member Author

I fixed the previous gdcm build failure on Darwin in another PR but there's now a new Darwin-specific error in that dependency.

So was it finally resolved? I think we can temporarily not enable test before solving the problem.

It was possible to remove gdcm from the test inputs.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 13, 2024
@bcdarwin bcdarwin force-pushed the update-python3-pylibjpeg-libjpeg branch from b4f46cd to ea418a3 Compare January 3, 2025 05:59
@bcdarwin bcdarwin changed the title python312Packages.pylibjpeg-libjpeg: 2.1.0 -> 2.2.0; enable tests python312Packages.pylibjpeg-libjpeg: 2.1.0 -> 2.3.0; enable tests Jan 3, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@bcdarwin bcdarwin force-pushed the update-python3-pylibjpeg-libjpeg branch from ea418a3 to de7a794 Compare January 4, 2025 04:56
@bcdarwin bcdarwin changed the title python312Packages.pylibjpeg-libjpeg: 2.1.0 -> 2.3.0; enable tests python312Packages.pylibjpeg-libjpeg: 2.2.0 -> 2.3.0; enable tests Jan 4, 2025
@bcdarwin bcdarwin removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@bcdarwin bcdarwin force-pushed the update-python3-pylibjpeg-libjpeg branch from de7a794 to 4566d06 Compare January 11, 2025 23:29
@bcdarwin bcdarwin changed the title python312Packages.pylibjpeg-libjpeg: 2.2.0 -> 2.3.0; enable tests python312Packages.pylibjpeg-libjpeg: enable tests Jan 11, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jan 11, 2025
@github-actions github-actions bot added the 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux label Jan 11, 2025
@bcdarwin bcdarwin force-pushed the update-python3-pylibjpeg-libjpeg branch from 4566d06 to 74102eb Compare January 11, 2025 23:37
@bcdarwin bcdarwin force-pushed the update-python3-pylibjpeg-libjpeg branch from 74102eb to 022b5ad Compare January 12, 2025 21:34
@FliegendeWurst FliegendeWurst merged commit ec484e7 into NixOS:master Jan 13, 2025
24 of 27 checks passed
@bcdarwin bcdarwin deleted the update-python3-pylibjpeg-libjpeg branch January 13, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants