Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 24.05] llvmPackages_{13,14,15,16,17,18,git}: commonify the default.nix #329706

Merged
merged 5 commits into from
Jul 25, 2024
Merged

[Backport 24.05] llvmPackages_{13,14,15,16,17,18,git}: commonify the default.nix #329706

merged 5 commits into from
Jul 25, 2024

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jul 24, 2024 •
edited
Loading

Description of changes

Backport of the fantastic #325175, thanks @RossComputerGuy! No hashes should be changed.

Also backports #191698 because that's basically no rebuilds, and removed some conflicts.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ShamrockLee @Ericson2314
clang-tools: format with nixfmt (Nix RFC 166)
ffeb5e9 
Format default.nix with nixfmt in accordance with Nix RFC 166.

Manually Place the comments above the corresponding argument.

(cherry picked from commit ff60b6d)
@ShamrockLee @Ericson2314
clang-tools: move into llvmPackages
42eaf65 
(cherry picked from commit eb572c4)
@ShamrockLee @Ericson2314
clang-tools_*: move to aliases
6378f52 
(cherry picked from commit 86e5c53)
@Ericson2314 Ericson2314 force-pushed the backport-325175-to-release-24.05 branch from 40ce4f8 to 387a561 Compare July 24, 2024 17:50
@Ericson2314
Copy link
Member Author

Sorry for the review spam!

@Ericson2314 Ericson2314 removed the 6.topic: stdenv Standard environment label Jul 24, 2024
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jul 24, 2024
This was referenced Jul 24, 2024
Merged
Merged
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Jul 24, 2024
@ofborg ofborg bot requested a review from Patryk27 July 24, 2024 19:55
@Ericson2314
Copy link
Member Author 

 Changed Paths
aarch64-darwin	llvmPackages_12.clang-tools
x86_64-linux	llvmPackages_12.clang-tools
aarch64-linux	llvmPackages_12.clang-tools
x86_64-darwin	llvmPackages_12.clang-tools

Looks good!

@Ericson2314 Ericson2314 merged commit 6a68f91 into NixOS:release-24.05 Jul 25, 2024
31 of 35 checks passed
@Ericson2314 Ericson2314 deleted the backport-325175-to-release-24.05 branch July 25, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

@Patryk27 Patryk27 Awaiting requested review from Patryk27

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: stdenv Standard environment 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ericson2314 @ShamrockLee @RossComputerGuy