[Backport release-24.05] nixos/systemd-networkd: add PREF64 related options #327190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b867cc2)
github-actions
bot
added
6.topic: nixos
We can expose the PLAT prefix to the client via DNS64 so clatd is able to determine the prefix dynamically. We can also test that some systemd-networkd PREF64 settings work as expected when exposed on the router. (cherry picked from commit d4d5fd7)
ofborg
bot
added
10.rebuild-darwin: 0
jmbaur
approved these changes
Jul 15, 2024
Is the compatibility the same as the rest of the 24.05 networkd options are with master? I thought the old structure was made into warnings on master, not incompatible. |
wegank
added
the
12.approvals: 1
flokli
added
the
9.needs: reporter feedback
It should be compatible. I did not test it. When backporting, the question was if I use the code as it is and add the function |
|
Let's please test this before cherry-picking to a stable release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Backport of #318604
I adapted the changes to the structure. So the options are not compatible to the master branch. If it is better, I can provide a 100% compatible backport, which then does not completely look like the other code parts.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.