Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] Fix nix flake show --all-systems from failing #326161

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-24.05, triggered by a label in #320639.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@grahamc
Copy link
Member

grahamc commented Jul 10, 2024

(closing pending a double-check elsewhere...)

@grahamc grahamc closed this Jul 10, 2024
@grahamc grahamc reopened this Jul 10, 2024
@github-actions github-actions bot added 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library labels Jul 10, 2024
@grahamc
Copy link
Member

grahamc commented Jul 10, 2024

Confirmed we're still getting the error this PR fixes.

@RossComputerGuy
Copy link
Member

Confirmed we're still getting the error this PR fixes.

The same exact one? Would be strange that we still get the libressl or bootstrap errors.

@grahamc
Copy link
Member

grahamc commented Jul 10, 2024

Yeah, the exact same bootstrap error:

evaluating 'checks.armv5tel-linux.nixosSystemAcceptsLib'...
      error:
             … while calling the 'head' builtin
               at /nix/store/i9syjxw0famqkabw2d01n723m3sc7vdn-source/lib/attrsets.nix:1575:11:
               1574|         || pred here (elemAt values 1) (head values) then
               1575|           head values
                   |           ^
               1576|         else

             … while evaluating the attribute 'value'
               at /nix/store/i9syjxw0famqkabw2d01n[72](https://github.com/DeterminateSystems/flakehub-mirror/actions/runs/9880125171/job/27287937454#step:7:74)3m3sc7vdn-source/lib/modules.nix:809:9:
                808|     in warnDeprecation opt //
                809|       { value = builtins.addErrorContext "while evaluating the option `${showOption loc}':" value;
                   |         ^
                810|         inherit (res.defsFinal') highestPrio;

             … while evaluating the option `system.build.toplevel':

             … while evaluating definitions from `/nix/store/i9syjxw0famqkabw2d01n723m3sc7vdn-source/nixos/modules/system/activation/top-level.nix':

             (stack trace truncated; use '--show-trace' to show the full, detailed trace)

             error: missing bootstrap url for platform armv5te-unknown-linux-gnueabi

...which I think makes sense, because the PR which fixed it in master never was backported to stable. Right?

@grahamc
Copy link
Member

grahamc commented Jul 10, 2024

At any rate, this PR fixes the issue, and nix flake show --all-systems works again.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 10, 2024
@RossComputerGuy
Copy link
Member

At any rate, this PR fixes the issue, and nix flake show --all-systems works again.

Gotcha, I understand now. I thought you were mentioning that this PR didn't work in 24.05.

@cole-h
Copy link
Member

cole-h commented Jul 10, 2024

Ignoring the failed formatting check because the files that are failing as "not formatted" were not touched here.

@cole-h cole-h merged commit e9e6878 into release-24.05 Jul 10, 2024
21 of 22 checks passed
@cole-h cole-h deleted the backport-320639-to-release-24.05 branch July 10, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants