Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerdevil: build with ddcutil support #325966

Closed

Conversation

HurricanePootis
Copy link

Description of changes

Powerdevil supports changing external monitor brightness via ddcutil, which sends DDC protocol messages over an I2C bus to the external monitor. However, powerdevil needs to be built with ddcutil and needs user access for the i2c bus. Therefore, I added ddcutil to the powerdevil package and enabled i2c along with powerdevil in the plasma module.

Shoutout @getchoo for the help!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 9, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 9, 2024
@ofborg ofborg bot requested review from mjm, LunNova and ilya-fedin July 10, 2024 00:45
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 10, 2024
@K900
Copy link
Contributor

K900 commented Jul 10, 2024

This has been brought up before. DDC/CI is very unreliable, and using it incorrectly can lead to permanently messing up your hardware. It should not be enabled by default.

@K900 K900 closed this Jul 10, 2024
@HurricanePootis
Copy link
Author

HurricanePootis commented Jul 10, 2024

If you're talking about previous KDE versions, at least starting with version 6.0, KDE has refined their approach to using libddcutil as explained in [this blog](Starting with Plasma 6.0.4, our DDC/CI code was restructured so that a monitor is only hogged for the short time it takes to change the brightness. ddcutil works again as intended in a Plasma session.) here. Furthermore, distros like Arch have enabled ddcutil as of recent, and everything seems to be fine now.

If not enabled by default, could an module be made for users who want and have tested ddc on their system?

@K900
Copy link
Contributor

K900 commented Jul 10, 2024

No, that's not the issue. The issue is that ddcutil, and DDC/CI in general, provides no way to enumerate devices, and has to blindly poke I2C buses and hope the right thing is on the other end, which can severely confuse other I2C hardware.

@HurricanePootis
Copy link
Author

Alright, I appreciate the information. Thanks for taking the time for a response 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants