-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-cli: move to by-name, nixfmt #325950
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
FWIW: The treewide format PR won’t touch files that have had open PRs in the past while, and will enforce formatting changed files on every new PR. So it wouldn’t reformat this file now, and it would actually enforce doing what @superherointj did here. The message you quoted was in the context of whether to hold off on doing mass reformats before the formatter exactly matches the RFC formatting guidelines, as an argument for reformatting as much of the tree ASAP as possible; see e.g. #322537 (comment). There’s already been a lot of small‐scale formatting and I’m not sure it makes sense to add every single commit to |
@emilazy I really think we should add it, git blame gives a lot of helpful info for packages of this size. |
Ah, I missed just how big this is :) It may be a good idea, then. Though I wonder how well |
The repo will be formatted anyway. Which can cause breakages, for example, update scripts (#310700). I will add the commit to |
b8adeba
to
b918e48
Compare
azure-cli: move to by-name, nixfmt
I have not included
extensions-generated.nix
at this point in time.Goal here is minimalist, to just establish a minimal base for a subsequent refactor.
CC @katexochen @obreitwi