nixos/modules/services/logging: Remove top-level with lib; #325936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
pyrox0
force-pushed
the
logging-modules-remove-with-lib
branch
from
8cbd40f to
e6d6062
Compare
pyrox0
changed the title
pyrox0
force-pushed
the
logging-modules-remove-with-lib
branch
from
e6d6062 to
cad46cc
Compare
pyrox0
force-pushed
the
logging-modules-remove-with-lib
branch
from
cad46cc to
5b0ba17
Compare
pyrox0
force-pushed
the
logging-modules-remove-with-lib
branch
from
5b0ba17 to
63b78b5
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Still looking for a review on this. It's been ready to merge for a month with no objections as far as I can see. |
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This removes all usage of
with lib;under nixos/modules/services/logging. This is similar in scope to #306640, and is related to removingwith lib;since it's an antipattern. See #208242 for more information on that.I've run all applicable NixOS tests, and there are no behavioral changes, so there should be no incompatibilities.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.